From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 2/8] drm/i915: Gen2 FBC1 CFB pitch wants 32B units Date: Thu, 12 Dec 2013 14:54:47 +0200 Message-ID: <1386852887.6866.0.camel@intelbox> References: <1385652602-8528-1-git-send-email-ville.syrjala@linux.intel.com> <1385652602-8528-3-git-send-email-ville.syrjala@linux.intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2043007224==" Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 5846BFA949 for ; Thu, 12 Dec 2013 04:54:54 -0800 (PST) In-Reply-To: <1385652602-8528-3-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============2043007224== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-W3UzHwsCMkzGpNlwP6pW" --=-W3UzHwsCMkzGpNlwP6pW Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2013-11-28 at 17:29 +0200, ville.syrjala@linux.intel.com wrote: > From: Ville Syrj=C3=A4l=C3=A4 >=20 > On gen2 the compressed frame buffer pitch is specified in 32B units > rather than the 64B units used on gen3+. >=20 > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/intel_pm.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel= _pm.c > index 614549b..1dee34c 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -103,8 +103,11 @@ static void i8xx_enable_fbc(struct drm_crtc *crtc, > if (fb->pitches[0] < cfb_pitch) > cfb_pitch =3D fb->pitches[0]; > =20 > - /* FBC_CTL wants 64B units */ > - cfb_pitch =3D (cfb_pitch / 64) - 1; > + /* FBC_CTL wants 32B or 64B units */ > + if (IS_GEN2(dev)) > + cfb_pitch =3D (cfb_pitch / 32) - 1; > + else > + cfb_pitch =3D (cfb_pitch / 64) - 1; > plane =3D intel_crtc->plane =3D=3D 0 ? FBC_CTL_PLANEA : FBC_CTL_PLANEB; > =20 > /* Clear old tags */ --=-W3UzHwsCMkzGpNlwP6pW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAABAgAGBQJSqbIXAAoJEORIIAnNuWDFtQIH/2Pw7ek5XHCyGHEua02+Jaux TlYzCMj6q9bbdlSGZ0HjpvVqlVzII39RCEiNsTPAIGlQ/OY9TdBaJjDFVmGpzCY/ dofbUX58dr0VrxKSJ9E8gKF6juOSmXGQWKUxikJU2KXv75F48Uo7nvi4EaVkGikW QErTRYUxtTsyioINQYIHE5RS4z1txnLUdD4wUcUMOSQhf25MICZpVOQRFqxeZoUW NWx2+pKgWGiEwzwkPipoeSs0OVRh3AMcwg9FtKfYD7yec6Ud21Aowv2l3Ekf2rkJ ndvNs8VXJJrwEUC21v7lYZr4mJZFxBQWS5P/7sOFSn7xiqVBq+Q+vkKJTDjbDGE= =QLKI -----END PGP SIGNATURE----- --=-W3UzHwsCMkzGpNlwP6pW-- --===============2043007224== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2043007224==--