From: Ben Widawsky <benjamin.widawsky@intel.com>
To: Intel GFX <intel-gfx@lists.freedesktop.org>
Cc: Patrick McMunn <doctorwhoguy@gmail.com>,
Ben Widawsky <ben@bwidawsk.net>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: [PATCH] shader-debugger: Use in tree gen4asm
Date: Fri, 20 Dec 2013 21:17:19 -0800 [thread overview]
Message-ID: <1387603039-25138-1-git-send-email-benjamin.widawsky@intel.com> (raw)
In-Reply-To: <2A60747E125A1447BDEB64729260025E25AEFDAB@FMSMSX104.amr.corp.intel.com>
Reported-by: Patrick McMunn <doctorwhoguy@gmail.com>
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
---
configure.ac | 21 ++++++++++-----------
debugger/system_routine/Makefile.am | 1 +
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/configure.ac b/configure.ac
index b43f45c..55cc78f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -133,13 +133,20 @@ if test "x$DUMPER" == xyes; then
fi
AM_CONDITIONAL(HAVE_DUMPER, [test "x$DUMPER" = xyes])
-# Define a configure option for the shadder debugger
+# Define a configure option for the shader debugger
AC_ARG_ENABLE(shader-debugger, AS_HELP_STRING([--enable-shader-debugger],
[Enable shader debugging support [autodetected]]),
[BUILD_SHADER_DEBUGGER="$enableval"], [BUILD_SHADER_DEBUGGER=auto])
-# Shadder debugger depends on python3, intel-genasm and objcopy
+# Shader debugger depends on python3, intel-genasm and objcopy
if test "x$BUILD_SHADER_DEBUGGER" != xno; then
+ GEN4ASM = assembler/intel-gen4asm
+ # Check that the assembler is built
+ if test "$enable_assembler" = xno; then
+ AC_MSG_ERROR([Shader debugger requested, but assembler not build not found.])
+ BUILD_SHADER_DEBUGGER=no
+ fi
+
# Check Python 3 is installed
if test "$PYTHON" = ":" ; then
if test "x$BUILD_SHADER_DEBUGGER" = xyes; then
@@ -148,15 +155,7 @@ if test "x$BUILD_SHADER_DEBUGGER" != xno; then
BUILD_SHADER_DEBUGGER=no
fi
fi
- # Check for the Intel Chipset assembler compiler
- AC_PATH_PROGS([GEN4ASM], intel-gen4asm)
- if test -z "$GEN4ASM" ; then
- if test "x$BUILD_SHADER_DEBUGGER" = xyes; then
- AC_MSG_ERROR([Shader debugger requested, but intel-gen4asm not found.])
- else
- BUILD_SHADER_DEBUGGER=no
- fi
- fi
+
# Check for the objcopy GNU binary utiliy command
AC_PATH_PROGS([OBJCOPY], objcopy)
if test -z "$OBJCOPY" ; then
diff --git a/debugger/system_routine/Makefile.am b/debugger/system_routine/Makefile.am
index 03f0f0f..95d8fb6 100644
--- a/debugger/system_routine/Makefile.am
+++ b/debugger/system_routine/Makefile.am
@@ -3,6 +3,7 @@ noinst_PROGRAMS = eviction_macro sr tiny
nodist_sr_SOURCES = sr.c
nodist_tiny_SOURCES = tiny.c
+GEN4ASM = $(top_builddir)/assembler/intel-gen4asm
GEN4ASM_FLAGS = -g6 -a -b
ASM_CPPFLAGS = \
-x assembler-with-cpp \
--
1.8.5.2
next prev parent reply other threads:[~2013-12-21 5:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAKS+cu0pZMHKoR4wEuDdA9thHzqvnQbkDP2sEGOErDSBigXZhA@mail.gmail.com>
2013-12-19 12:29 ` Minor bug in intel-gpu-tools Zanoni, Paulo R
2013-12-21 5:17 ` Ben Widawsky [this message]
2013-12-30 12:57 ` [PATCH] shader-debugger: Use in tree gen4asm Paulo Zanoni
2013-12-30 18:43 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387603039-25138-1-git-send-email-benjamin.widawsky@intel.com \
--to=benjamin.widawsky@intel.com \
--cc=ben@bwidawsk.net \
--cc=doctorwhoguy@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox