From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: [PATCH 5/6] tests/kms_flip: don't leak the connector_config struct Date: Mon, 30 Dec 2013 13:56:52 -0200 Message-ID: <1388419013-17016-5-git-send-email-przanoni@gmail.com> References: <1388419013-17016-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qe0-f47.google.com (mail-qe0-f47.google.com [209.85.128.47]) by gabe.freedesktop.org (Postfix) with ESMTP id DE94DF9D8A for ; Mon, 30 Dec 2013 07:57:15 -0800 (PST) Received: by mail-qe0-f47.google.com with SMTP id t7so11368418qeb.6 for ; Mon, 30 Dec 2013 07:57:15 -0800 (PST) In-Reply-To: <1388419013-17016-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org From: Paulo Zanoni ... in case we can't find a compatible mode. We already have config[0], we can't return without freeing it first. Caught by Valgrind. Signed-off-by: Paulo Zanoni --- tests/kms_flip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 78e179e..c43a26f 100644 --- a/tests/kms_flip.c +++ b/tests/kms_flip.c @@ -954,8 +954,10 @@ static void connector_find_compatible_mode(int crtc_idx0, int crtc_idx1, return; if (kmstest_get_connector_config(drm_fd, o->_connector[1], - 1 << crtc_idx1, &config[1]) < 0) + 1 << crtc_idx1, &config[1]) < 0) { + kmstest_free_connector_config(&config[0]); return; + } mode[0] = &config[0].default_mode; mode[1] = &config[1].default_mode; -- 1.8.3.1