From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915: avoid unclaimed registers when capturing the error state Date: Tue, 07 Jan 2014 16:07:30 +0200 Message-ID: <1389103650.30164.9.camel@intelbox> References: <1387559381-1515-1-git-send-email-przanoni@gmail.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0769814124==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id DA5E5FAEA8 for ; Tue, 7 Jan 2014 06:07:38 -0800 (PST) In-Reply-To: <1387559381-1515-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org --===============0769814124== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-tbkTFHUfll49p1HJdasN" --=-tbkTFHUfll49p1HJdasN Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2013-12-20 at 15:09 -0200, Paulo Zanoni wrote: > From: Paulo Zanoni >=20 > We're iterating over the CPU transcoders, so check for the correct > power domain. >=20 > This fixes many "unclaimed register" error messages. >=20 > This can be reproduced by the IGT test mentioned below, but we still > get a FAIL when we run it. >=20 > Testcase: igt/kms_lip/flip-vs-panning-vs-hang > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_display.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 >=20 > I didn't bisect to check, but it really really looks like a regression fr= om > "drm/i915: add intel_display_power_enabled_sw() for use in atomic ctx". Yep, that was an overlook on my part:/ The fix looks ok: Reviewed-by: Imre Deak >=20 >=20 >=20 > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/= intel_display.c > index 4d1357a..4d4b4bc 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -11459,7 +11459,8 @@ intel_display_capture_error_state(struct drm_devi= ce *dev) > enum transcoder cpu_transcoder =3D transcoders[i]; > =20 > error->transcoder[i].power_domain_on =3D > - intel_display_power_enabled_sw(dev, POWER_DOMAIN_PIPE(i)); > + intel_display_power_enabled_sw(dev, > + POWER_DOMAIN_TRANSCODER(cpu_transcoder)); > if (!error->transcoder[i].power_domain_on) > continue; > =20 --=-tbkTFHUfll49p1HJdasN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAABAgAGBQJSzAoiAAoJEORIIAnNuWDFtcUIAKeeOj+DqHZVUKEPdwvB+Os5 /N3kQ2blCL1YwVTGMhz03VhciFfg8cM+2X3wVoZQ/gxLThS+ehh0r1mKPySLGqRv rkLpLKDp4T/vgE852+l84/PdQcfxVbBtIbHO5cguOWnrmVmxCxpb4V4v/Kjw0JzG fHh+h/ITgvVGN9wtRqRZqTIXY99NH+ytiqiUeBD8ZCMeEECGl8ztrhaAsxGCkIql 0WKg13Q/bOBgszzMwkrsbB72jj+rEGz6KrzRRNHvx+m+9XbAY3KAF7zf+1Dzcf6j vv/S5bBXhgcWkznApSk4XzGlFWiWZWTQLNpc0ypO3N23s8dwIFW1Au4C9XFYorg= =sBYG -----END PGP SIGNATURE----- --=-tbkTFHUfll49p1HJdasN-- --===============0769814124== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0769814124==--