From: deepak.s@intel.com
To: intel-gfx@lists.freedesktop.org
Cc: Deepak S <deepak.s@intel.com>
Subject: [PATCH v3 1/3] drm/i915: Disable/Enable PM Intrrupts based on the current freq.
Date: Thu, 9 Jan 2014 19:31:08 +0530 [thread overview]
Message-ID: <1389276070-22591-2-git-send-email-deepak.s@intel.com> (raw)
In-Reply-To: <1389276070-22591-1-git-send-email-deepak.s@intel.com>
From: Deepak S <deepak.s@intel.com>
When current delay is already at max delay, Let's disable the PM UP
THRESHOLD INTRRUPTS, so that we will not get further interrupts until
current delay is less than max delay, Also request for the PM DOWN
THRESHOLD INTRRUPTS to indicate the decrease in clock freq. and
viceversa for PM DOWN THRESHOLD INTRRUPTS.
v2: Use bool variables (Daniel)
v3: Fix Interrupt masking bit (Deepak)
Signed-off-by: Deepak S <deepak.s@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 3 +++
drivers/gpu/drm/i915/i915_irq.c | 31 +++++++++++++++++++++++++++++--
drivers/gpu/drm/i915/intel_pm.c | 3 +++
3 files changed, 35 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index cc8afff..d49e674 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -943,6 +943,9 @@ struct intel_gen6_power_mgmt {
u8 rp0_delay;
u8 hw_max;
+ bool rp_up_masked;
+ bool rp_down_masked;
+
int last_adj;
enum { LOW_POWER, BETWEEN, HIGH_POWER } power;
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 1d44c79..e87d47a 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -988,7 +988,20 @@ static void gen6_pm_rps_work(struct work_struct *work)
adj *= 2;
else
adj = 1;
- new_delay = dev_priv->rps.cur_delay + adj;
+
+ if (dev_priv->rps.cur_delay >= dev_priv->rps.max_delay) {
+ I915_WRITE(GEN6_PMINTRMSK,
+ I915_READ(GEN6_PMINTRMSK) | 1 << 5);
+ dev_priv->rps.rp_up_masked = true;
+ new_delay = dev_priv->rps.cur_delay;
+ } else
+ new_delay = dev_priv->rps.cur_delay + adj;
+
+ if (dev_priv->rps.rp_down_masked) {
+ I915_WRITE(GEN6_PMINTRMSK,
+ I915_READ(GEN6_PMINTRMSK) & ~(1 << 4));
+ dev_priv->rps.rp_down_masked = false;
+ }
/*
* For better performance, jump directly
@@ -1007,7 +1020,21 @@ static void gen6_pm_rps_work(struct work_struct *work)
adj *= 2;
else
adj = -1;
- new_delay = dev_priv->rps.cur_delay + adj;
+
+ if (dev_priv->rps.cur_delay <= dev_priv->rps.min_delay) {
+ I915_WRITE(GEN6_PMINTRMSK,
+ I915_READ(GEN6_PMINTRMSK) | 1 << 4);
+ dev_priv->rps.rp_down_masked = true;
+ new_delay = dev_priv->rps.cur_delay;
+ } else
+ new_delay = dev_priv->rps.cur_delay + adj;
+
+ if (dev_priv->rps.rp_up_masked) {
+ I915_WRITE(GEN6_PMINTRMSK,
+ I915_READ(GEN6_PMINTRMSK) & ~(1 << 5));
+ dev_priv->rps.rp_up_masked = false;
+ }
+
} else { /* unknown event */
new_delay = dev_priv->rps.cur_delay;
}
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 469170c..9c950e4 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3628,6 +3628,9 @@ static void valleyview_enable_rps(struct drm_device *dev)
vlv_gpu_freq(dev_priv, dev_priv->rps.rpe_delay),
dev_priv->rps.rpe_delay);
+ dev_priv->rps.rp_up_masked = false;
+ dev_priv->rps.rp_down_masked = false;
+
valleyview_set_rps(dev_priv->dev, dev_priv->rps.rpe_delay);
gen6_enable_rps_interrupts(dev);
--
1.8.4.2
next prev parent reply other threads:[~2014-01-09 14:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 14:01 [PATCH v2 0/3] VLV Turbo/rps + RC6 workaround deepak.s
2014-01-09 14:01 ` deepak.s [this message]
2014-01-13 23:01 ` [PATCH v3 1/3] drm/i915: Disable/Enable PM Intrrupts based on the current freq Jesse Barnes
2014-01-14 9:21 ` Daniel Vetter
2014-01-14 9:23 ` S, Deepak
2014-01-16 5:47 ` S, Deepak
2014-01-09 14:01 ` [PATCH v2 2/3] drm/i915/vlv: WA to fix Voltage not getting dropped to Vmin when Gfx is power gated deepak.s
2014-01-13 22:53 ` Jesse Barnes
2014-01-14 9:12 ` S, Deepak
2014-01-09 14:01 ` [PATCH 3/3] drm/i915/vlv: WA for Turbo and RC6 to work together deepak.s
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389276070-22591-2-git-send-email-deepak.s@intel.com \
--to=deepak.s@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox