Re: [PATCH 0/4] drm/i915: Small step towards atomic modeset

[Imre Deak <imre.deak@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1531 bytes --]

On Fri, 2014-01-10 at 11:28 +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Looks ok to me. On the series:
Reviewed-by: Imre Deak <imre.deak@intel.com>

> 
> I started to think a bit about how the code should look for doing a full
> modeset for more than one pipe at a time. This is how far I got yesterday.
> 
> I suppose the next thing would be moving the PLL calculations into compute
> config stage, and then actually computing a new pipe config for more than
> one pipe.
> 
> After that we could improve the IVB bifurcate stuff to handle cases where
> pipe B is already enabled w/ > 2 FDI lanes, and then we try to light up
> pipe C. Assuming pipe B bandwidth can be reduced sufficiently to fit into
> two lanes, such an operation should succeed.
> 
> But I think I'll try to finish off some of my other pending stuff before
> I continue with this.
> 
> I fired this up on an IVB briefly and things seem fine. I didn't actually
> test the VLV cdclk change due to lack of hardware.
> 
> Ville Syrjälä (4):
>   drm/i915: Pre-compute pipe enabled state
>   drm/i915: Prepare to track new pipe config per pipe
>   drm/i915: Use new_config and new_enabled to simplify the VLV cdclk
>     code
>   drm/i915: Don't oops if the initial modeset fails
> 
>  drivers/gpu/drm/i915/intel_display.c | 140 +++++++++++++++++++++++++++--------
>  drivers/gpu/drm/i915/intel_drv.h     |   3 +
>  2 files changed, 111 insertions(+), 32 deletions(-)
> 


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx