* [PATCH] i915: send D1 opregion notification
@ 2014-01-13 21:32 Kristen Carlson Accardi
2014-01-14 9:26 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Kristen Carlson Accardi @ 2014-01-13 21:32 UTC (permalink / raw)
To: intel-gfx
The opregion notification for runtime suspend should be D1, not D3.
This is to maintain compatibility with firmware.
Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 61fb9fc..a6c370a 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -925,7 +925,7 @@ static int i915_runtime_suspend(struct device *device)
del_timer_sync(&dev_priv->gpu_error.hangcheck_timer);
dev_priv->pm.suspended = true;
- intel_opregion_notify_adapter(dev, PCI_D3cold);
+ intel_opregion_notify_adapter(dev, PCI_D1);
return 0;
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] i915: send D1 opregion notification
2014-01-13 21:32 [PATCH] i915: send D1 opregion notification Kristen Carlson Accardi
@ 2014-01-14 9:26 ` Daniel Vetter
2014-01-14 19:19 ` Jesse Barnes
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2014-01-14 9:26 UTC (permalink / raw)
To: Kristen Carlson Accardi; +Cc: intel-gfx
On Mon, Jan 13, 2014 at 01:32:45PM -0800, Kristen Carlson Accardi wrote:
> The opregion notification for runtime suspend should be D1, not D3.
> This is to maintain compatibility with firmware.
>
> Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 61fb9fc..a6c370a 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -925,7 +925,7 @@ static int i915_runtime_suspend(struct device *device)
>
> del_timer_sync(&dev_priv->gpu_error.hangcheck_timer);
> dev_priv->pm.suspended = true;
> - intel_opregion_notify_adapter(dev, PCI_D3cold);
> + intel_opregion_notify_adapter(dev, PCI_D1);
This needs a bigger comment and some mention on which platforms we exactly
need this ... Or do the bios people plan to stick to this for bdw/vlv and
all the further stuff?
-Daniel
>
> return 0;
> }
> --
> 1.8.3.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i915: send D1 opregion notification
2014-01-14 9:26 ` Daniel Vetter
@ 2014-01-14 19:19 ` Jesse Barnes
2014-01-14 23:06 ` Kristen Carlson Accardi
0 siblings, 1 reply; 5+ messages in thread
From: Jesse Barnes @ 2014-01-14 19:19 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx, Kristen Carlson Accardi
On Tue, 14 Jan 2014 10:26:02 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, Jan 13, 2014 at 01:32:45PM -0800, Kristen Carlson Accardi wrote:
> > The opregion notification for runtime suspend should be D1, not D3.
> > This is to maintain compatibility with firmware.
> >
> > Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_drv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > index 61fb9fc..a6c370a 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.c
> > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > @@ -925,7 +925,7 @@ static int i915_runtime_suspend(struct device *device)
> >
> > del_timer_sync(&dev_priv->gpu_error.hangcheck_timer);
> > dev_priv->pm.suspended = true;
> > - intel_opregion_notify_adapter(dev, PCI_D3cold);
> > + intel_opregion_notify_adapter(dev, PCI_D1);
>
> This needs a bigger comment and some mention on which platforms we exactly
> need this ... Or do the bios people plan to stick to this for bdw/vlv and
> all the further stuff?
Doc # would help too, even if it's CDI or internal only... I don't know
where to find this info, or if I did I've forgotten.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i915: send D1 opregion notification
2014-01-14 19:19 ` Jesse Barnes
@ 2014-01-14 23:06 ` Kristen Carlson Accardi
2014-01-14 23:08 ` Jesse Barnes
0 siblings, 1 reply; 5+ messages in thread
From: Kristen Carlson Accardi @ 2014-01-14 23:06 UTC (permalink / raw)
To: Jesse Barnes; +Cc: intel-gfx
On Tue, 14 Jan 2014 11:19:44 -0800
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Tue, 14 Jan 2014 10:26:02 +0100
> Daniel Vetter <daniel@ffwll.ch> wrote:
>
> > On Mon, Jan 13, 2014 at 01:32:45PM -0800, Kristen Carlson Accardi wrote:
> > > The opregion notification for runtime suspend should be D1, not D3.
> > > This is to maintain compatibility with firmware.
> > >
> > > Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
> > > ---
> > > drivers/gpu/drm/i915/i915_drv.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > > index 61fb9fc..a6c370a 100644
> > > --- a/drivers/gpu/drm/i915/i915_drv.c
> > > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > > @@ -925,7 +925,7 @@ static int i915_runtime_suspend(struct device *device)
> > >
> > > del_timer_sync(&dev_priv->gpu_error.hangcheck_timer);
> > > dev_priv->pm.suspended = true;
> > > - intel_opregion_notify_adapter(dev, PCI_D3cold);
> > > + intel_opregion_notify_adapter(dev, PCI_D1);
> >
> > This needs a bigger comment and some mention on which platforms we exactly
> > need this ... Or do the bios people plan to stick to this for bdw/vlv and
> > all the further stuff?
>
> Doc # would help too, even if it's CDI or internal only... I don't know
> where to find this info, or if I did I've forgotten.
>
> Thanks,
hahhah, you crack me up with all this "doc" stuff. There is no doc.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i915: send D1 opregion notification
2014-01-14 23:06 ` Kristen Carlson Accardi
@ 2014-01-14 23:08 ` Jesse Barnes
0 siblings, 0 replies; 5+ messages in thread
From: Jesse Barnes @ 2014-01-14 23:08 UTC (permalink / raw)
To: Kristen Carlson Accardi; +Cc: intel-gfx
On Tue, 14 Jan 2014 15:06:46 -0800
Kristen Carlson Accardi <kristen@linux.intel.com> wrote:
> On Tue, 14 Jan 2014 11:19:44 -0800
> Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>
> > On Tue, 14 Jan 2014 10:26:02 +0100
> > Daniel Vetter <daniel@ffwll.ch> wrote:
> >
> > > On Mon, Jan 13, 2014 at 01:32:45PM -0800, Kristen Carlson Accardi wrote:
> > > > The opregion notification for runtime suspend should be D1, not D3.
> > > > This is to maintain compatibility with firmware.
> > > >
> > > > Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/i915_drv.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > > > index 61fb9fc..a6c370a 100644
> > > > --- a/drivers/gpu/drm/i915/i915_drv.c
> > > > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > > > @@ -925,7 +925,7 @@ static int i915_runtime_suspend(struct device *device)
> > > >
> > > > del_timer_sync(&dev_priv->gpu_error.hangcheck_timer);
> > > > dev_priv->pm.suspended = true;
> > > > - intel_opregion_notify_adapter(dev, PCI_D3cold);
> > > > + intel_opregion_notify_adapter(dev, PCI_D1);
> > >
> > > This needs a bigger comment and some mention on which platforms we exactly
> > > need this ... Or do the bios people plan to stick to this for bdw/vlv and
> > > all the further stuff?
> >
> > Doc # would help too, even if it's CDI or internal only... I don't know
> > where to find this info, or if I did I've forgotten.
> >
> > Thanks,
>
> hahhah, you crack me up with all this "doc" stuff. There is no doc.
Can you file an HSD or something on that internally? Seems like it
should at least be part of the OpRegion spec or something...
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-01-14 23:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-13 21:32 [PATCH] i915: send D1 opregion notification Kristen Carlson Accardi
2014-01-14 9:26 ` Daniel Vetter
2014-01-14 19:19 ` Jesse Barnes
2014-01-14 23:06 ` Kristen Carlson Accardi
2014-01-14 23:08 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox