Re: [PATCH v2] i915: send D1 opregion notification

Daniel Vetter
2014-01-15T09:00:09Z

On Tue, Jan 14, 2014 at 03:36:15PM -0800, Kristen Carlson Accardi wrote:
> The opregion notification for runtime suspend is currently D1, not D3.
>
> Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
Queued for -next, thanks for the patch.
-Daniel

> ---
> drivers/gpu/drm/i915/i915_drv.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 61fb9fc..5a26d76 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -925,7 +925,15 @@ static int i915_runtime_suspend(struct device *device)
>
> del_timer_sync(&dev_priv->gpu_error.hangcheck_timer);
> dev_priv->pm.suspended = true;
> - intel_opregion_notify_adapter(dev, PCI_D3cold);
> +
> + /*
> + * current versions of firmware which depend on this opregion
> + * notification have repurposed the D1 definition to mean
> + * "runtime suspended" vs. what you would normally expect (D3)
> + * to distinguish it from notifications that might be sent
> + * via the suspend path.
> + */
> + intel_opregion_notify_adapter(dev, PCI_D1);
>
> return 0;
> }
> --
> 1.8.3.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch