From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 2/2] drm/i915: don't disable DP port after a failed link training Date: Thu, 16 Jan 2014 19:05:40 +0200 Message-ID: <1389891940.1153.4.camel@intelbox> References: <1389890158-30938-1-git-send-email-imre.deak@intel.com> <1389890158-30938-2-git-send-email-imre.deak@intel.com> <20140116165814.GA4864@nuc-i3427.alporthouse.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0533414573==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 72A33105A14 for ; Thu, 16 Jan 2014 09:06:05 -0800 (PST) In-Reply-To: <20140116165814.GA4864@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0533414573== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-FEuAM22ZR7d0+Wm3eIGr" --=-FEuAM22ZR7d0+Wm3eIGr Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2014-01-16 at 16:58 +0000, Chris Wilson wrote: > On Thu, Jan 16, 2014 at 06:35:58PM +0200, Imre Deak wrote: > > The driver shouldn't disable the DP port itself, but let userspace do i= t > > through a modeset. See the previous patch for the reasoning. >=20 > Eh, this occurs not just during link detection, but also during > intel_enable_dp, so this comment does not hold. The biggest > issue of this function is that it can fail but never propagates > that failure, which itself breaks the users and API expectations, > as neither the driver or userspace is aware that it is required to > takeaction. Right, I haven't thought about this and the commit message is incorrect. So in the end with proper error handling it's gonna be the kernel that disables the port along with the rest of the pipe. I agree with danvet, that we could still have this before a final solution. (with a fixed commit message). --Imre --=-FEuAM22ZR7d0+Wm3eIGr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAABAgAGBQJS2BFkAAoJEORIIAnNuWDFqj8IAPGCFhdtL7boVL7rY0V2Maak h1XeZtR4LNChATKmCJFQ9woGPDfUGkogKmscu/bz1qAJoaC5EMvgYxPfTNOO9t2y svJBBMXND+CCgmMyZVA/XtiHJPRwZBGjpsfCL9ijkvTUjU2SU450PGJyVT7mVpAH 6wmF4fPFhv8B58z2GFXhyKaNyuzx1OhOjmmbqGUa0T5iZF1EXLhx6dtWNpKi1pUU elxeyhSy7mfLGwshodtEWxJQGfJwY5NRDYX5m3pEJL7xFOp3UAqACMExfUIWZc6Z cp6yuJKeb5Y0w9TAiVgl3hof997ajm4Owmf2RGUcafxKhq6mz9H12/xAC8EMo8A= =YVG7 -----END PGP SIGNATURE----- --=-FEuAM22ZR7d0+Wm3eIGr-- --===============0533414573== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0533414573==--