Re: [PATCH 2/2] drm/i915: don't disable DP port after a failed link training

Chris Wilson
2014-01-16T16:58:18Z

On Thu, Jan 16, 2014 at 06:35:58PM +0200, Imre Deak wrote:
> The driver shouldn't disable the DP port itself, but let userspace do it
> through a modeset. See the previous patch for the reasoning.

Eh, this occurs not just during link detection, but also during
intel_enable_dp, so this comment does not hold. The biggest
issue of this function is that it can fail but never propagates
that failure, which itself breaks the users and API expectations,
as neither the driver or userspace is aware that it is required to
takeaction.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre