Re: [PATCH 2/2] drm/i915: don't disable DP port after a failed link training

Imre Deak
2014-01-16T17:06:05Z

[-- Attachment #1.1: Type: text/plain, Size: 941 bytes --]

On Thu, 2014-01-16 at 16:58 +0000, Chris Wilson wrote:
> On Thu, Jan 16, 2014 at 06:35:58PM +0200, Imre Deak wrote:
> > The driver shouldn't disable the DP port itself, but let userspace do it
> > through a modeset. See the previous patch for the reasoning.
>
> Eh, this occurs not just during link detection, but also during
> intel_enable_dp, so this comment does not hold. The biggest
> issue of this function is that it can fail but never propagates
> that failure, which itself breaks the users and API expectations,
> as neither the driver or userspace is aware that it is required to
> takeaction.

Right, I haven't thought about this and the commit message is incorrect.
So in the end with proper error handling it's gonna be the kernel that
disables the port along with the rest of the pipe.

I agree with danvet, that we could still have this before a final
solution. (with a fixed commit message).

--Imre

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org