From: Ben Widawsky <benjamin.widawsky@intel.com>
To: Intel GFX <intel-gfx@lists.freedesktop.org>
Cc: Ben Widawsky <benjamin.widawsky@intel.com>
Subject: [PATCH 0/9] Broadwel RC6 & RPS
Date: Tue, 28 Jan 2014 20:25:37 -0800 [thread overview]
Message-ID: <1390969547-1018-1-git-send-email-benjamin.widawsky@intel.com> (raw)
This patch series implements RC6 and RPS for Broadwell. Most of the work
had already been done with the initial merge of Broadwell support,
however, there were a couple of missed things, and enough stuff had
moved around. The big change is the addition of the interrupt handlers.
I am mostly interested in getting RC6 working. RC6 enabling is critical
to getting other teams up and running. I decided to table RPS as well
because the code isn't quite as isolated as I would like, and the work
didn't seem that difficult.
IMPORTANT NOTE: With the current patch series, I do see rc6 residency
(not tested rps very much) however, the very first batch always GPU
hangs. At this point I have no evidence to lead me to believe it's
anything but a software bug on my part, but I've yet to track it down.
After this first hang, everything /seems/ stable, again, in limited
testing.
Again, my primary goal of getting this out now is allowing other teams
who are doing power work to move ahead, and also get some of the trivial
fixes moved ahead now. If I had to guess, I'm betting "Implement a basic
PM interrupt handler" might cause some fuss. If we can get the patches
reviewed, retested, and merged - that would be great.
I have pushed this to my fdo bdw-rc6 branch again with the hope that
relevant parties may use the patch series for testing. This branch is
based upon the latest available nightly, with 2 workarounds from Ken.
git://people.freedesktop.org/~bwidawsk/drm-intel bdw-rc6
A quick summary:
1-4 Are cleanups
5 is a cleanup + bug fix
6-7 are small bug fixes
8 handler for all of the PM interrupts
9 is the simple "on switch"
Ben Widawsky (9):
drm/i915: Clarify RC6 enabling
drm/i915: Stop pretending VLV has rc6+
drm/i915: Just print rc6 facts
drm/i915/bdw: Use centralized rc6 info print
drm/i915/bdw: Extract rp_state_caps logic
drm/i915/bdw: Set initial rps freq to nominal
drm/i915/bdw: RPS frequency bits are the same as HSW
drm/i915/bdw: Implement a basic PM interrupt handler
drm/i915/bdw: Enable RC6
drivers/gpu/drm/i915/i915_irq.c | 80 +++++++++++++++++++++++++++++++++--
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_drv.h | 2 +
drivers/gpu/drm/i915/intel_pm.c | 91 +++++++++++++++++++++++++++-------------
4 files changed, 141 insertions(+), 33 deletions(-)
--
1.8.5.3
next reply other threads:[~2014-01-29 4:25 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 4:25 Ben Widawsky [this message]
2014-01-29 4:25 ` [PATCH 1/9] drm/i915: Clarify RC6 enabling Ben Widawsky
2014-02-06 13:38 ` Rodrigo Vivi
[not found] ` <CAOh5HuUmDmAC9Nuu3DWYO2kU+Q5kyHyxSmF4rjADaY1iY6=RaQ@mail.gmail.com>
2014-02-07 5:30 ` S, Deepak
2014-02-18 3:01 ` [PATCH 00/11] [v2] BDW RPS + RC6 + rps fixlets Ben Widawsky
2014-02-18 3:01 ` [PATCH 01/11] drm/i915: Reorganize the overclock code Ben Widawsky
2014-02-18 3:01 ` [PATCH 02/11] drm/i915: Fix coding style for RPS Ben Widawsky
2014-02-18 3:01 ` [PATCH 03/11] drm/i915: Rename and comment all the RPS *stuff* Ben Widawsky
2014-02-18 19:03 ` [PATCH 03/11] [v2] " Ben Widawsky
2014-02-22 13:37 ` [PATCH 03/11] " Chris Wilson
2014-02-22 19:34 ` Ben Widawsky
2014-02-22 19:37 ` Chris Wilson
2014-02-22 19:40 ` Ben Widawsky
2014-02-22 20:08 ` Chris Wilson
2014-02-25 0:54 ` Ben Widawsky
2014-02-22 19:38 ` Ben Widawsky
2014-02-22 20:14 ` Chris Wilson
2014-03-19 1:27 ` Ben Widawsky
2014-03-19 2:38 ` Ben Widawsky
2014-03-19 6:49 ` Chris Wilson
2014-02-18 3:01 ` [PATCH 04/11] drm/i915: Remove extraneous MMIO for RPS Ben Widawsky
2014-02-18 3:01 ` [PATCH 05/11] drm/i915: remove rps local variables Ben Widawsky
2014-02-18 3:01 ` [PATCH 06/11] drm/i915/bdw: Set initial rps freq to nominal Ben Widawsky
2014-02-18 3:01 ` [PATCH 07/11] drm/i915/bdw: Extract rp_state_caps logic Ben Widawsky
2014-02-18 3:01 ` [PATCH 08/11] drm/i915/bdw: RPS frequency bits are the same as HSW Ben Widawsky
2014-02-18 3:01 ` [PATCH 09/11] drm/i915/bdw: Implement a basic PM interrupt handler Ben Widawsky
2014-02-18 3:01 ` [PATCH 10/11] drm/i915/bdw: Enable RC6 Ben Widawsky
2014-02-18 3:01 ` [PATCH 11/11] drm/i915/bdw: Ensure a context is loaded before RC6 Ben Widawsky
2014-02-18 3:03 ` [PATCH 11/11] [v2] " Ben Widawsky
2014-02-18 3:56 ` [PATCH 11/11] [v3] " Ben Widawsky
2014-02-20 6:27 ` [PATCH 11/11] [v4] " Ben Widawsky
2014-03-04 14:30 ` Daniel Vetter
2014-03-20 0:41 ` Ben Widawsky
2014-03-20 13:42 ` Daniel Vetter
2014-03-20 17:30 ` Jesse Barnes
2014-03-20 20:12 ` Jesse Barnes
2014-03-20 1:31 ` [PATCH 00/12] [v3] BDW RPS + RC6 + rps fixlets Ben Widawsky
2014-03-20 1:31 ` [PATCH 01/12] drm/i915: Reorganize the overclock code Ben Widawsky
2014-03-20 7:23 ` Chris Wilson
2014-03-20 1:31 ` [PATCH 02/12] drm/i915: Fix coding style for RPS Ben Widawsky
2014-03-20 7:31 ` Chris Wilson
2014-03-24 10:30 ` Deepak S
2014-03-20 1:31 ` [PATCH 03/12] drm/i915: Store the HW min frequency as min_freq Ben Widawsky
2014-03-20 7:29 ` Chris Wilson
2014-03-24 10:31 ` Deepak S
2014-03-20 1:31 ` [PATCH 04/12] drm/i915: Rename and comment all the RPS *stuff* Ben Widawsky
2014-03-20 7:01 ` Chris Wilson
2014-03-20 1:31 ` [PATCH 05/12] drm/i915: Remove extraneous MMIO for RPS Ben Widawsky
2014-03-20 7:30 ` Chris Wilson
2014-03-20 1:31 ` [PATCH 06/12] drm/i915: remove rps local variables Ben Widawsky
2014-03-20 7:30 ` Chris Wilson
2014-03-20 13:46 ` Daniel Vetter
2014-03-20 1:31 ` [PATCH 07/12] drm/i915/bdw: Set initial rps freq to RP0 Ben Widawsky
2014-03-20 7:24 ` Chris Wilson
2014-03-22 18:42 ` Ben Widawsky
2014-03-22 21:06 ` Chris Wilson
2014-03-24 19:27 ` Ben Widawsky
2014-03-20 1:31 ` [PATCH 08/12] drm/i915/bdw: Extract rp_state_caps logic Ben Widawsky
2014-03-20 7:28 ` Chris Wilson
2014-03-22 18:46 ` Ben Widawsky
2014-03-20 1:31 ` [PATCH 09/12] drm/i915/bdw: RPS frequency bits are the same as HSW Ben Widawsky
2014-03-20 1:31 ` [PATCH 10/12] drm/i915/bdw: Implement a basic PM interrupt handler Ben Widawsky
2014-03-24 19:30 ` Ben Widawsky
2014-03-20 1:31 ` [PATCH 11/12] drm/i915/bdw: Ensure a context is loaded before RC6 Ben Widawsky
2014-03-20 7:35 ` Chris Wilson
2014-03-20 1:31 ` [PATCH 12/12] drm/i915/bdw: Enable RC6 Ben Widawsky
2014-03-24 10:27 ` Deepak S
2014-01-29 4:25 ` [PATCH 2/9] drm/i915: Stop pretending VLV has rc6+ Ben Widawsky
2014-02-06 13:39 ` Rodrigo Vivi
[not found] ` <CAOh5HuXxFqRixpPSeOpi=1t2sL=sVfmjdMR445dEQBozg1Z43w@mail.gmail.com>
2014-02-07 5:42 ` S, Deepak
2014-01-29 4:25 ` [PATCH 3/9] drm/i915: Just print rc6 facts Ben Widawsky
2014-02-06 13:41 ` Rodrigo Vivi
[not found] ` <CAOh5HuW+_5n=zfDSf_F1aT+v7xzdm_GwUxKC5t8g6_LVCX6X_g@mail.gmail.com>
2014-02-07 5:44 ` S, Deepak
2014-01-29 4:25 ` [PATCH 4/9] drm/i915/bdw: Use centralized rc6 info print Ben Widawsky
2014-02-06 13:42 ` Rodrigo Vivi
2014-02-11 16:12 ` Daniel Vetter
2014-02-14 20:34 ` Ben Widawsky
2014-02-14 20:41 ` Chris Wilson
2014-02-17 19:41 ` Ben Widawsky
[not found] ` <CAOh5HuVu0vvQNFKt2FhVf9CrXQa47WAfaqWP2EHp=mBMgExTkQ@mail.gmail.com>
2014-02-07 5:46 ` S, Deepak
2014-01-29 4:25 ` [PATCH 5/9] drm/i915/bdw: Extract rp_state_caps logic Ben Widawsky
2014-01-29 4:25 ` [PATCH 5/9] drm/i915/bdw: Set rp_state_caps Ben Widawsky
2014-02-06 13:45 ` Rodrigo Vivi
[not found] ` <CAOh5HuUqCUM-2-yxCbPcCZ53yTxN+8Q5+syiAXqa86Vp47T70A@mail.gmail.com>
2014-02-07 6:10 ` S, Deepak
2014-01-29 4:25 ` [PATCH 6/9] drm/i915/bdw: Set initial rps freq to nominal Ben Widawsky
2014-01-29 4:25 ` [PATCH 7/9] drm/i915/bdw: RPS frequency bits are the same as HSW Ben Widawsky
2014-02-06 13:52 ` Rodrigo Vivi
[not found] ` <CAOh5HuU8bnYppf7D5k39QuuDkbHCUVznuVHzvd2dW1mDN0GpBA@mail.gmail.com>
2014-02-07 6:25 ` S, Deepak
2014-01-29 4:25 ` [PATCH 8/9] drm/i915/bdw: Implement a basic PM interrupt handler Ben Widawsky
2014-02-06 14:15 ` Rodrigo Vivi
2014-02-17 20:01 ` Ben Widawsky
[not found] ` <CAOh5HuXYmUmGM2tDGO6KCT9Q1V6znbAwQf5OoC27++078bvfRg@mail.gmail.com>
2014-02-07 6:43 ` S, Deepak
2014-01-29 4:25 ` [PATCH 9/9] drm/i915/bdw: Enable RC6 Ben Widawsky
2014-02-06 13:54 ` Rodrigo Vivi
2014-02-17 20:04 ` Ben Widawsky
2014-02-17 20:07 ` Ben Widawsky
[not found] ` <CAOh5HuW-f4xdojasEP3wkSoVH3W1NJNdPACafgnPfVujFe4fjw@mail.gmail.com>
2014-02-07 6:47 ` S, Deepak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390969547-1018-1-git-send-email-benjamin.widawsky@intel.com \
--to=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox