[PATCH 07/11] drm/i915/bdw: Extract rp_state_caps logic

Ben Widawsky
2014-02-18T03:02:03Z

We have a need for duplicated parsing of the RP_STATE_CAPS register (and
the setting of the associated fields). To reuse some code, we can
extract the function into a simple helper.

This patch also addresses the fact that we missed doing this for gen8,
something we should have done anyway.

This could be two patches, one to extract, and one to add gen8, but it's
trivial enough that I think one is fine. I will accept a request to
split it. Please notice the fix addressed by v2 below.

Valleyview is left untouched because it is different.

v2: Logically rebased on top of
commit dd0a1aa19bd3d7203e58157b84cea78bbac605ac
Author: Jeff McGee <jeff.mcgee@intel.com>
Date: Tue Feb 4 11:32:31 2014 -0600

drm/i915: Restore rps/rc6 on reset

Note with the above change the fix for gen8 is also handled (which was
not the case in Jeff's original patch).

Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
---
drivers/gpu/drm/i915/intel_pm.c | 35 +++++++++++++++++++++--------------
1 file changed, 21 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 4fe9a94..ac8419d 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3245,6 +3245,25 @@ static void gen6_enable_rps_interrupts(struct drm_device *dev)
I915_WRITE(GEN6_PMINTRMSK, ~enabled_intrs);
}

+static void parse_rp_state_cap(struct drm_i915_private *dev_priv, u32 rp_state_cap)
+{
+
+ /* In units of 50MHz */
+ dev_priv->rps.nominal_freq = (rp_state_cap >> 16) & 0xff;
+ dev_priv->rps.min_freq_hardlimit = (rp_state_cap >> 8) & 0xff;
+ dev_priv->rps.max_freq_hardlimit = (rp_state_cap >> 0) & 0xff;
+ dev_priv->rps.max_freq_overclock = dev_priv->rps.max_freq_hardlimit;
+ dev_priv->rps.nominal_freq = dev_priv->rps.min_freq_hardlimit;
+ dev_priv->rps.cur_freq = 0;
+
+ /* Preserve min/max settings in case of re-init */
+ if (dev_priv->rps.max_freq_softlimit == 0)
+ dev_priv->rps.max_freq_softlimit = dev_priv->rps.max_freq_hardlimit;
+
+ if (dev_priv->rps.min_freq_softlimit == 0)
+ dev_priv->rps.min_freq_softlimit = dev_priv->rps.min_freq_hardlimit;
+}
+
static void gen8_enable_rps(struct drm_device *dev)
{
struct drm_i915_private *dev_priv = dev->dev_private;
@@ -3263,6 +3282,7 @@ static void gen8_enable_rps(struct drm_device *dev)
I915_WRITE(GEN6_RC_CONTROL, 0);

rp_state_cap = I915_READ(GEN6_RP_STATE_CAP);
+ parse_rp_state_cap(dev_priv, rp_state_cap);

/* 2b: Program RC6 thresholds.*/
I915_WRITE(GEN6_RC6_WAKE_RATE_LIMIT, 40 << 16);
@@ -3351,20 +3371,7 @@ static void gen6_enable_rps(struct drm_device *dev)
rp_state_cap = I915_READ(GEN6_RP_STATE_CAP);
gt_perf_status = I915_READ(GEN6_GT_PERF_STATUS);

- /* In units of 50MHz */
- dev_priv->rps.nominal_freq = (rp_state_cap >> 16) & 0xff;
- dev_priv->rps.min_freq_hardlimit = (rp_state_cap >> 8) & 0xff;
- dev_priv->rps.max_freq_hardlimit = (rp_state_cap >> 0) & 0xff;
- dev_priv->rps.max_freq_overclock = dev_priv->rps.max_freq_hardlimit;
- dev_priv->rps.nominal_freq = dev_priv->rps.min_freq_hardlimit;
- dev_priv->rps.cur_freq = 0;
-
- /* Preserve min/max settings in case of re-init */
- if (dev_priv->rps.max_freq_softlimit == 0)
- dev_priv->rps.max_freq_softlimit = dev_priv->rps.max_freq_hardlimit;
-
- if (dev_priv->rps.min_freq_softlimit == 0)
- dev_priv->rps.min_freq_softlimit = dev_priv->rps.min_freq_hardlimit;
+ parse_rp_state_cap(dev_priv, rp_state_cap);

/* disable the counters and set deterministic thresholds */
I915_WRITE(GEN6_RC_CONTROL, 0);
--
1.8.5.5