From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH] drm/i915: demote opregion excessive timeout WARN_ONCE to DRM_INFO
Date: Fri, 31 Jan 2014 13:41:08 +0200 [thread overview]
Message-ID: <1391168468-9072-1-git-send-email-jani.nikula@intel.com> (raw)
In-Reply-To: <20140131093802.GR29091@nuc-i3427.alporthouse.com>
The WARN is a bit too verbose, make it a DRM_INFO that gets printed
once.
While at it, fix the typo in DSLP.
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_opregion.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
index 46d288055345..0fae017c4c7b 100644
--- a/drivers/gpu/drm/i915/intel_opregion.c
+++ b/drivers/gpu/drm/i915/intel_opregion.c
@@ -263,7 +263,11 @@ static int swsci(struct drm_device *dev, u32 function, u32 parm, u32 *parm_out)
dslp = 50;
} else if (dslp > 1500) {
/* Hey bios, trust must be earned. */
- WARN_ONCE(1, "excessive driver sleep timeout (DSPL) %u\n", dslp);
+ static bool warned;
+ if (!warned) {
+ DRM_INFO("excessive driver sleep timeout (DSLP) %u\n", dslp);
+ warned = true;
+ }
dslp = 1500;
}
--
1.7.9.5
next prev parent reply other threads:[~2014-01-31 11:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 9:31 [PATCH] drm/i915: Increase OpRegion timeout Daniel Vetter
2014-01-31 9:38 ` Chris Wilson
2014-01-31 11:41 ` Jani Nikula [this message]
2014-01-31 11:41 ` [PATCH] drm/i915: demote opregion excessive timeout WARN_ONCE to DRM_INFO Ville Syrjälä
2014-01-31 13:21 ` Jani Nikula
2014-01-31 13:26 ` Ville Syrjälä
2014-01-31 11:43 ` Chris Wilson
2014-01-31 11:55 ` Jani Nikula
2014-01-31 11:56 ` Chris Wilson
2014-01-31 13:49 ` [PATCH 1/2] drm: add DRM_INFO_ONCE() to print a one-time DRM_INFO() message Jani Nikula
2014-01-31 13:49 ` [PATCH 2/2] drm/i915: demote opregion excessive timeout WARN_ONCE to DRM_INFO_ONCE Jani Nikula
2014-01-31 13:48 ` Chris Wilson
2014-02-04 20:09 ` Daniel Vetter
2014-01-31 11:42 ` [PATCH] drm/i915: Increase OpRegion timeout Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391168468-9072-1-git-send-email-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox