From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915: fix dp/sdvo i2c cleanup Date: Tue, 04 Feb 2014 18:57:51 +0200 Message-ID: <1391533071.19773.5.camel@intelbox> References: <1390554955-26380-1-git-send-email-imre.deak@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2133767546==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id CA24E11D640 for ; Tue, 4 Feb 2014 08:58:03 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org --===============2133767546== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-cpWTm5wWtcbDdxhw1zfB" --=-cpWTm5wWtcbDdxhw1zfB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2014-02-04 at 17:13 +0100, Daniel Vetter wrote: > On Fri, Jan 24, 2014 at 10:15 AM, Imre Deak wrote: > > Atm we try to remove the connector's i2c sysfs entry too late in the > > encoder's destroy callback. By that time the kobject used as the parent > > for all connector sysfs entries is already removed when we do an early > > removal of all connector sysfs entries in intel_modeset_cleanup(). Fix > > this by adding an early_destory encoder callback, where we remove the > > encoder's i2c adapter. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D70523 > > > > Signed-off-by: Imre Deak >=20 > Ok, I guess with Greg's clarification this seems to be the correct > fix. But I'm not too happy about the ->early_destroy since that > inversion of control is usually a bad sign for wrong layering. Imo > it'd be better to push all the encoder clean down into each encoders > ->destroy callback and then move the dp aux cleanup at the right > place. So essentially we'd need to push the > intel_panel_destroy_backlight and drm_sysfs_connector_remove calls > down. That also allows us to only cleanup the backlight on edp/lvds. >=20 > Comments or too insane an idea? Agreed about ->early_destroy being hacky, it was the fast and usual solution for reordering something in drm :) I'll check this later / discuss with Jani about reworking this based on your suggestion. --Imre --=-cpWTm5wWtcbDdxhw1zfB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAABAgAGBQJS8RwPAAoJEORIIAnNuWDFT6EH/RML2mypmX3smY2A4nPfKibf zz/GxJW8NjJASfxVMaZqMUPNsRnMpbRSBqCbbJ7d+xnvbTm2Ff7hcbEGArSvw896 BZAOgH1rVGKdZW7B61PNwH0xFCuMB+tgcN+V0SpKSF6WjtymSViPLFKX+6gc3GMQ VfQ3qPYIVSdOySt55UgvtDJZKfW/XWHQkE2KvfYt92wwWFY4tJoGbDFm1/AY84n9 ApDfGX2lzTLBv21ifIUE1fNCzCpwjP0omx4CXGDZ8PLObKumYnGFlm3MS6koRtHj Py4mUON6R1evHfyL5OCcwAA9rYBaC2NE/wggdHeIOGPiItTWBmT2AUrisT1rvAA= =sHXM -----END PGP SIGNATURE----- --=-cpWTm5wWtcbDdxhw1zfB-- --===============2133767546== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2133767546==--