public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel Graphics <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Fix correct FIFO size for Baytrail
Date: Wed, 12 Feb 2014 19:24:00 +0200	[thread overview]
Message-ID: <1392225840.3028.1.camel@intelbox> (raw)
In-Reply-To: <20140207185847.GE17001@phenom.ffwll.local>


[-- Attachment #1.1: Type: text/plain, Size: 1231 bytes --]

On Fri, 2014-02-07 at 19:58 +0100, Daniel Vetter wrote:
> On Fri, Feb 07, 2014 at 05:58:16PM +0200, Ville Syrjälä wrote:
> > On Fri, Feb 07, 2014 at 08:43:12PM +0530, Vijay Purushothaman wrote:
> > > B-spec says the FIFO total size is 512. So fix this to 512.
> > > 
> > > Signed-off-by: Vijay Purushothaman <vijay.a.purushothaman@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/i915_reg.h |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > > index cc3ea04..fb73031 100644
> > > --- a/drivers/gpu/drm/i915/i915_reg.h
> > > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > > @@ -3395,7 +3395,7 @@
> > >  #define I915_FIFO_LINE_SIZE	64
> > >  #define I830_FIFO_LINE_SIZE	32
> > >  
> > > -#define VALLEYVIEW_FIFO_SIZE	255
> > > +#define VALLEYVIEW_FIFO_SIZE	511
> > >  #define G4X_FIFO_SIZE		127
> > >  #define I965_FIFO_SIZE		512
> > >  #define I945_FIFO_SIZE		127
> > 
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Queued for -next, thanks for the patch.
> -Daniel

This breaks DP on my BYT, I get bad flicker with it. Reverting only this
one fixes the issue.

--Imre


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2014-02-12 17:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 15:13 [PATCH] drm/i915: Fix correct FIFO size for Baytrail Vijay Purushothaman
2014-02-07 15:58 ` Ville Syrjälä
2014-02-07 16:26   ` Vijay Purushothaman
2014-02-07 19:38     ` Ville Syrjälä
2014-02-07 18:58   ` Daniel Vetter
2014-02-12 17:24     ` Imre Deak [this message]
2014-02-12 17:27       ` Imre Deak
2014-02-12 17:53         ` Daniel Vetter
2014-02-13 15:46         ` Purushothaman, Vijay A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392225840.3028.1.camel@intelbox \
    --to=imre.deak@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox