From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915: Fix correct FIFO size for Baytrail Date: Wed, 12 Feb 2014 19:27:28 +0200 Message-ID: <1392226048.3028.2.camel@intelbox> References: <1391785992-28063-1-git-send-email-vijay.a.purushothaman@intel.com> <20140207155816.GY3891@intel.com> <20140207185847.GE17001@phenom.ffwll.local> <1392225840.3028.1.camel@intelbox> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1255116644==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 8744BFAF03 for ; Wed, 12 Feb 2014 09:27:44 -0800 (PST) In-Reply-To: <1392225840.3028.1.camel@intelbox> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Vijay Purushothaman Cc: Intel Graphics List-Id: intel-gfx@lists.freedesktop.org --===============1255116644== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-AUQGi4QfsGWAnBs+3jmH" --=-AUQGi4QfsGWAnBs+3jmH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2014-02-12 at 19:24 +0200, Imre Deak wrote: > On Fri, 2014-02-07 at 19:58 +0100, Daniel Vetter wrote: > > On Fri, Feb 07, 2014 at 05:58:16PM +0200, Ville Syrj=C3=A4l=C3=A4 wrote= : > > > On Fri, Feb 07, 2014 at 08:43:12PM +0530, Vijay Purushothaman wrote: > > > > B-spec says the FIFO total size is 512. So fix this to 512. > > > >=20 > > > > Signed-off-by: Vijay Purushothaman > > > > --- > > > > drivers/gpu/drm/i915/i915_reg.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >=20 > > > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915= /i915_reg.h > > > > index cc3ea04..fb73031 100644 > > > > --- a/drivers/gpu/drm/i915/i915_reg.h > > > > +++ b/drivers/gpu/drm/i915/i915_reg.h > > > > @@ -3395,7 +3395,7 @@ > > > > #define I915_FIFO_LINE_SIZE 64 > > > > #define I830_FIFO_LINE_SIZE 32 > > > > =20 > > > > -#define VALLEYVIEW_FIFO_SIZE 255 > > > > +#define VALLEYVIEW_FIFO_SIZE 511 > > > > #define G4X_FIFO_SIZE 127 > > > > #define I965_FIFO_SIZE 512 > > > > #define I945_FIFO_SIZE 127 > > >=20 > > > Reviewed-by: Ville Syrj=C3=A4l=C3=A4 > >=20 > > Queued for -next, thanks for the patch. > > -Daniel >=20 > This breaks DP on my BYT, I get bad flicker with it. Reverting only this > one fixes the issue. Adding Vijay. --Imre --=-AUQGi4QfsGWAnBs+3jmH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJS+68AAAoJEORIIAnNuWDF0CQIAOsWpnp5zPdHCoz5IYOYoLHh iWqwt+2QhTSWWp8yB4HECNmYm9U3krJkpsGfW+pg7JCShxZk33Gb2b0AvoA3/4Lz 3YK9NPb/3UCWnZEa+ouriT1W8aVuYZOyoz6wu0KJf5WTMTBZKIdokHV2cBXhO2fq 2xCpo93suWBG17lKScRVlWf0mx4elX/O/ne7Zn1Tfz3cThKzrk1wDFygFuAUnXSA 8x2cb/d62PTCQviDddk0Bm3RPsooOEYOHyfgAu37efI1XH3zr3YphczWbNeYY1GS 8wU2KmA/jaOQR/NVGvDUS8rX+4iN+WVJKhCIva1CaEuI23TZ6bmyX36cw7jv3Rc= =ijHR -----END PGP SIGNATURE----- --=-AUQGi4QfsGWAnBs+3jmH-- --===============1255116644== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1255116644==--