From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 6/9] Revert "drm/i915/bdw: Limit GTT to 2GB" Date: Wed, 19 Feb 2014 21:14:39 +0200 Message-ID: <1392837279.19792.48.camel@intelbox> References: <1392244132-6806-1-git-send-email-benjamin.widawsky@intel.com> <1392244132-6806-7-git-send-email-benjamin.widawsky@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0958294680==" Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id C132EFAED7 for ; Wed, 19 Feb 2014 11:15:08 -0800 (PST) In-Reply-To: <1392244132-6806-7-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org --===============0958294680== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-R3vu7p5PUXj3aIE8tsYf" --=-R3vu7p5PUXj3aIE8tsYf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2014-02-12 at 14:28 -0800, Ben Widawsky wrote: > This reverts commit 3a2ffb65eec6dbda2fd8151894f51c18b42c8d41. >=20 > Now that the code is fixed to use smaller allocations, it should be safe > to let the full GGTT be used on DW. >=20 > The testcase for this is anything which uses more than half of the GTT, > thus eclipsing the old limit. >=20 > Signed-off-by: Ben Widawsky After the remaining issues fixed, on this one: Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i= 915_gem_gtt.c > index 5299acc..2c2121d 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -1733,11 +1733,6 @@ static inline unsigned int gen8_get_total_gtt_size= (u16 bdw_gmch_ctl) > bdw_gmch_ctl &=3D BDW_GMCH_GGMS_MASK; > if (bdw_gmch_ctl) > bdw_gmch_ctl =3D 1 << bdw_gmch_ctl; > - if (bdw_gmch_ctl > 4) { > - WARN_ON(!i915.preliminary_hw_support); > - return 4<<20; > - } > - > return bdw_gmch_ctl << 20; > } > =20 --=-R3vu7p5PUXj3aIE8tsYf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTBQKfAAoJEORIIAnNuWDF39QH/3OIT01CvfMWpMaxg9ZWvGhr /WOAVgxqa9p2xqxMEIvDXl5yvatDII7hVnRLAKsZF6w/wli3E6Dji/endGM2jxzf 48usOCM+eB/N4FAd6tuxhxODglZ8fO/9TSrdHzVt5T7ZWYD6UyxVd+iQLwDo6uXR U8mLjIlHdH0R4XcAg16blVFK0xEmFc3EAaGhCKtlxNzjMvR4p0JYs1bOK6oDDFPv ThbKRJAZhXUL3J3CVSvNaLp8RK0hgQyXgt2662cIcb4r/ETtWDf9GcHhvBcgV51s fgtWbYVbzeC8QFxwWYgXx7HQQPktIf4CgPSRMQMmzzuJFAz985APkT7DBn+eJ0o= =22G/ -----END PGP SIGNATURE----- --=-R3vu7p5PUXj3aIE8tsYf-- --===============0958294680== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0958294680==--