Re: [PATCH] [v2] drm/i915/bdw: Add FBC support

Ben Widawsky
2014-03-05T21:37:22Z

On Wed, Mar 05, 2014 at 12:00:18PM +0100, Daniel Vetter wrote:
> On Fri, Feb 21, 2014 at 04:06:47PM -0300, Paulo Zanoni wrote:
> > 2014-02-20 21:01 GMT-03:00 Ben Widawsky <benjamin.widawsky@intel.com>:
> > > This got lost when we shuffled around our internal branch and
> > > GEN7_FEATURES macro. There were no HW changes to support FBC, so we just
> > > need to set the flag.
> > >
> > > v2: Don't allow FBC for any pipe but A on platforms with DDI. (Paulo)
> > >
> > > Cc: Daisy Sun <daisy.sun@intel.com>
> > > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> >
> > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Have you guys run the fbc igt testcase to make sure it actually works? In
> case it's broken I'll back it out again ...
>
> Queued for -next, thanks for the patch.
> -Daniel

Daisy, I was led to believe you actually tested this. Is that correct?

Daniel, BTW, we have an unimplemented FBC bugfix (basically disable) on
HSW that carries over to BDW. It was not implemented last time I checked
anyway. I tried to implement it, but I don't know the code well enough.
Feel free to sign me up for review if someone else does it.

Also, 4k displays have some issue with FBC. So we'll need to address
that.

--
Ben Widawsky, Intel Open Source Technology Center