From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 00/11] Runtime PM fixes
Date: Fri, 21 Feb 2014 13:52:17 -0300 [thread overview]
Message-ID: <1393001548-2883-1-git-send-email-przanoni@gmail.com> (raw)
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
Hi
This series contains a collection of fixes for problems I found on the runtime
PM code. All these problems either result in failure of some pm_pc8 test, or
result in a Kernel WARN/DRM_ERROR when running pm_pc8, or there is a patch in
this series that adds a WARN that will be triggered if we ever unfix the
problem. Notice that nothing comes from bugzilla reports (see below).
So the real fixes of this series are patches 1-5. Patches 6+ either only fix
debugfs files, or add more WARNs to make sure the problems we solve here remain
solved, or do small cleanups.
I did _not_ add Cc: stable@vger.kernel.org tags to the patches for the following
reasons reasons: (i) I simply don't know if we want them; (ii) I have other 44
patches that should be applied on top of these, so having part of the series in
-fixes and another in -next can be a mess; and (iii) runtime PM is still
disabled by default (although a simple sysfs write can enable it, and powertop
makes this even easier) and its autosuspend delay is set to 10s, plus 5ms of PC8
timeout, so the problems are either very hard or impossible to reproduce without
i915.pc8_timeout=0 (and that's why, I believe, we don't have bug reports for
these things). But if we wan to Cc stable, it's fine too: we can do this with
all the patches, or just with 1-5, or more.
Thanks,
Paulo
Chris Wilson (1):
drm/i915: Accurately track when we mark the hardware as idle/busy
Paulo Zanoni (10):
drm/i915: put runtime PM only at the end of intel_mark_idle
drm/i915: put runtime PM only when we actually release force_wake
drm/i915: get runtime PM at intel_set_mode
drm/i915: get runtime PM while trying to detect CRT
drm/i915: get/put runtime PM in more places at i915_debugfs.c
drm/i915: kill dev_priv->pc8.gpu_idle
drm/i915: call assert_device_not_suspended at gen6_force_wake_work
drm/i915: assert force wake is disabled when we runtime suspend
drm/i915: don't get/put runtime PM at the debugfs forcewake file
drm/i915: assert we're not runtime suspended when writing registers
drivers/gpu/drm/i915/i915_debugfs.c | 21 +++++++++++++---
drivers/gpu/drm/i915/i915_drv.c | 1 +
drivers/gpu/drm/i915/i915_drv.h | 19 ++++++++++-----
drivers/gpu/drm/i915/intel_crt.c | 26 ++++++++++++++------
drivers/gpu/drm/i915/intel_display.c | 47 ++++++++++++++----------------------
drivers/gpu/drm/i915/intel_pm.c | 3 +--
drivers/gpu/drm/i915/intel_uncore.c | 34 ++++++++++++++++++--------
7 files changed, 94 insertions(+), 57 deletions(-)
--
1.8.5.3
next reply other threads:[~2014-02-21 16:52 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 16:52 Paulo Zanoni [this message]
2014-02-21 16:52 ` [PATCH 01/11] drm/i915: Accurately track when we mark the hardware as idle/busy Paulo Zanoni
2014-02-21 16:55 ` Chris Wilson
2014-02-21 17:04 ` Paulo Zanoni
2014-02-21 17:27 ` Chris Wilson
2014-02-21 19:34 ` Paulo Zanoni
2014-03-05 13:13 ` Daniel Vetter
2014-03-05 13:15 ` Chris Wilson
2014-02-21 16:52 ` [PATCH 02/11] drm/i915: put runtime PM only at the end of intel_mark_idle Paulo Zanoni
2014-02-21 17:28 ` Jesse Barnes
2014-03-05 13:14 ` Daniel Vetter
2014-02-21 16:52 ` [PATCH 03/11] drm/i915: put runtime PM only when we actually release force_wake Paulo Zanoni
2014-02-21 17:34 ` Jesse Barnes
2014-02-21 20:08 ` Paulo Zanoni
2014-02-21 20:16 ` Jesse Barnes
2014-02-21 20:58 ` Paulo Zanoni
2014-03-05 13:17 ` Daniel Vetter
2014-02-21 16:52 ` [PATCH 04/11] drm/i915: get runtime PM at intel_set_mode Paulo Zanoni
2014-02-21 17:35 ` Jesse Barnes
2014-02-24 11:23 ` Imre Deak
2014-02-24 14:34 ` Paulo Zanoni
2014-02-28 13:07 ` Imre Deak
2014-03-05 13:25 ` Daniel Vetter
2014-03-06 16:30 ` Paulo Zanoni
2014-02-21 16:52 ` [PATCH 05/11] drm/i915: get runtime PM while trying to detect CRT Paulo Zanoni
2014-02-21 17:37 ` Jesse Barnes
2014-02-24 11:33 ` Imre Deak
2014-02-24 14:36 ` Paulo Zanoni
2014-02-21 16:52 ` [PATCH 06/11] drm/i915: get/put runtime PM in more places at i915_debugfs.c Paulo Zanoni
2014-02-21 17:41 ` Jesse Barnes
2014-02-21 17:46 ` Paulo Zanoni
2014-03-05 13:29 ` Daniel Vetter
2014-02-21 16:52 ` [PATCH 07/11] drm/i915: kill dev_priv->pc8.gpu_idle Paulo Zanoni
2014-02-28 13:50 ` Imre Deak
2014-02-28 20:11 ` Paulo Zanoni
2014-03-05 13:31 ` Daniel Vetter
2014-02-21 16:52 ` [PATCH 08/11] drm/i915: call assert_device_not_suspended at gen6_force_wake_work Paulo Zanoni
2014-02-21 18:05 ` Paulo Zanoni
2014-02-28 14:12 ` Imre Deak
2014-02-21 16:52 ` [PATCH 09/11] drm/i915: assert force wake is disabled when we runtime suspend Paulo Zanoni
2014-02-28 14:32 ` Imre Deak
2014-02-21 16:52 ` [PATCH 10/11] drm/i915: don't get/put runtime PM at the debugfs forcewake file Paulo Zanoni
2014-02-28 14:34 ` Imre Deak
2014-03-05 13:41 ` Daniel Vetter
2014-02-21 16:52 ` [PATCH 11/11] drm/i915: assert we're not runtime suspended when writing registers Paulo Zanoni
2014-02-28 15:16 ` Imre Deak
2014-03-05 13:44 ` Daniel Vetter
2014-03-05 13:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393001548-2883-1-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox