Re: [PATCH 01/11] drm/i915: Accurately track when we mark the hardware as idle/busy

Chris Wilson
2014-02-21T16:56:12Z

On Fri, Feb 21, 2014 at 01:52:18PM -0300, Paulo Zanoni wrote:
> From: Chris Wilson <chris@chris-wilson.co.uk>
>
> We currently call intel_mark_idle() too often, as we do so as a
> side-effect of processing the request queue. However, we the calls to
> intel_mark_idle() are expected to be paired with a call to
> intel_mark_busy() (or else we try to idle the hardware by accessing
> registers that are already disabled). Make the idle/busy tracking
> explicit to prevent the multiple calls.
>
> v2: From Paulo
> - Make it compile
> - Drop the __i915_add_request chunk
>
> Reported-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Tested-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 8 ++++++++
> drivers/gpu/drm/i915/intel_display.c | 9 +++++++++
> 2 files changed, 17 insertions(+)
>
>
> Chris did not reply to my review comments yet, so I just went and implemented
> them. We need at least an ACK form him here before merging.

Didn't see them... Why have you altered the logic?
-Chris

--
Chris Wilson, Intel Open Source Technology Centre