From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 04/20] drm/i915: add GEN5_IRQ_FINI
Date: Fri, 7 Mar 2014 20:10:20 -0300 [thread overview]
Message-ID: <1394233836-3827-5-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1394233836-3827-1-git-send-email-przanoni@gmail.com>
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
Same as the _INIT macro: the goal is to reuse the GEN8 macros, but
there are still some slight differences.
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 7be7da1..a9f173c 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -103,6 +103,11 @@ static const u32 hpd_status_i915[] = { /* i915 and valleyview are the same */
I915_WRITE(type##IIR, 0xffffffff); \
} while (0)
+#define GEN5_IRQ_FINI(type) do { \
+ I915_WRITE(type##IMR, 0xffffffff); \
+ I915_WRITE(type##IER, 0); \
+ I915_WRITE(type##IIR, I915_READ(type##IIR)); \
+} while (0)
/* For display hotplug interrupt */
static void
@@ -3304,22 +3309,16 @@ static void ironlake_irq_uninstall(struct drm_device *dev)
I915_WRITE(HWSTAM, 0xffffffff);
- I915_WRITE(DEIMR, 0xffffffff);
- I915_WRITE(DEIER, 0x0);
- I915_WRITE(DEIIR, I915_READ(DEIIR));
+ GEN5_IRQ_FINI(DE);
if (IS_GEN7(dev))
I915_WRITE(GEN7_ERR_INT, I915_READ(GEN7_ERR_INT));
- I915_WRITE(GTIMR, 0xffffffff);
- I915_WRITE(GTIER, 0x0);
- I915_WRITE(GTIIR, I915_READ(GTIIR));
+ GEN5_IRQ_FINI(GT);
if (HAS_PCH_NOP(dev))
return;
- I915_WRITE(SDEIMR, 0xffffffff);
- I915_WRITE(SDEIER, 0x0);
- I915_WRITE(SDEIIR, I915_READ(SDEIIR));
+ GEN5_IRQ_FINI(SDE);
if (HAS_PCH_CPT(dev) || HAS_PCH_LPT(dev))
I915_WRITE(SERR_INT, I915_READ(SERR_INT));
}
--
1.8.5.3
next prev parent reply other threads:[~2014-03-07 23:11 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 23:10 [PATCH 00/20] ILK+ interrupt improvements, v2 Paulo Zanoni
2014-03-07 23:10 ` [PATCH 01/20] drm/i915: add GEN5_IRQ_INIT macro Paulo Zanoni
2014-03-07 23:10 ` [PATCH 02/20] drm/i915: also use GEN5_IRQ_INIT with south display interrupts Paulo Zanoni
2014-03-07 23:10 ` [PATCH 03/20] drm/i915: use GEN8_IRQ_INIT on GEN5 Paulo Zanoni
2014-03-18 17:11 ` Ben Widawsky
2014-03-18 17:41 ` Daniel Vetter
2014-03-26 20:00 ` Paulo Zanoni
2014-03-26 21:37 ` Daniel Vetter
2014-03-27 12:06 ` Paulo Zanoni
2014-03-07 23:10 ` Paulo Zanoni [this message]
2014-03-07 23:10 ` [PATCH 05/20] drm/i915: don't forget to uninstall the PM IRQs Paulo Zanoni
2014-03-18 17:59 ` Ben Widawsky
2014-03-07 23:10 ` [PATCH 06/20] drm/i915: properly clear IIR at irq_uninstall on Gen5+ Paulo Zanoni
2014-03-11 8:25 ` Chris Wilson
2014-03-18 17:20 ` Ben Widawsky
2014-03-07 23:10 ` [PATCH 07/20] drm/i915: add GEN5_IRQ_INIT Paulo Zanoni
2014-03-18 18:16 ` Ben Widawsky
2014-03-07 23:10 ` [PATCH 08/20] drm/i915: check if IIR is still zero at postinstall on Gen5+ Paulo Zanoni
2014-03-18 18:20 ` Ben Widawsky
2014-03-19 8:28 ` Daniel Vetter
2014-03-19 17:50 ` Ben Widawsky
2014-03-27 13:34 ` Paulo Zanoni
2014-03-07 23:10 ` [PATCH 09/20] drm/i915: fix SERR_INT init/reset code Paulo Zanoni
2014-03-18 18:24 ` Ben Widawsky
2014-03-07 23:10 ` [PATCH 10/20] drm/i915: fix GEN7_ERR_INT " Paulo Zanoni
2014-03-18 19:42 ` Ben Widawsky
2014-03-07 23:10 ` [PATCH 11/20] drm/i915: fix open coded gen5_gt_irq_preinstall Paulo Zanoni
2014-03-07 23:10 ` [PATCH 12/20] drm/i915: extract ibx_irq_uninstall Paulo Zanoni
2014-03-07 23:10 ` [PATCH 13/20] drm/i915: call ibx_irq_uninstall from gen8_irq_uninstall Paulo Zanoni
2014-03-07 23:10 ` [PATCH 14/20] drm/i915: enable SDEIER later Paulo Zanoni
2014-03-18 20:29 ` Ben Widawsky
2014-03-27 14:39 ` Paulo Zanoni
2014-03-28 6:20 ` Ben Widawsky
2014-03-28 7:41 ` Daniel Vetter
2014-03-07 23:10 ` [PATCH 15/20] drm/i915: remove ibx_irq_uninstall Paulo Zanoni
2014-03-07 23:10 ` [PATCH 16/20] drm/i915: add missing intel_hpd_irq_uninstall Paulo Zanoni
2014-03-18 20:38 ` Ben Widawsky
2014-03-07 23:10 ` [PATCH 17/20] drm/i915: add ironlake_irq_reset Paulo Zanoni
2014-03-07 23:10 ` [PATCH 18/20] drm/i915: add gen8_irq_reset Paulo Zanoni
2014-03-18 20:43 ` Ben Widawsky
2014-03-27 14:48 ` Paulo Zanoni
2014-03-07 23:10 ` [PATCH 19/20] drm/i915: only enable HWSTAM interrupts on postinstall on ILK+ Paulo Zanoni
2014-03-07 23:10 ` [PATCH 20/20] drm/i915: add POSTING_READs to the IRQ init/reset macros Paulo Zanoni
2014-03-18 20:45 ` Ben Widawsky
2014-03-18 20:53 ` [PATCH 00/20] ILK+ interrupt improvements, v2 Ben Widawsky
2014-03-19 8:36 ` Daniel Vetter
2014-03-19 17:25 ` Ben Widawsky
2014-03-26 20:33 ` Paulo Zanoni
2014-03-26 20:54 ` Ben Widawsky
2014-03-26 21:35 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394233836-3827-5-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox