Re: [PATCH 0/6] SNB/BDW runtime PM

Imre Deak
2014-04-01T16:21:14Z

[-- Attachment #1.1: Type: text/plain, Size: 2597 bytes --]

On Fri, 2014-03-07 at 20:12 -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Hi
>
> This series depends on:
> - [PATCH 0/6] More runtime PM fixes
> - [PATCH 00/16] Merge PC8 with runtime PM, v3
> - [PATCH 00/20] ILK+ interrupt improvements, v2
>
> Patches 1 and 2 are the last pieces of my runtime PM rework, and patch 1 needs
> all the previous patches to be merged before it can be merged.
>
> Patch 3 adds runtime PM support to SNB. It's not widely tested and I haven't
> tested it for a while, but at some point this was all that was needed to make my
> SNB laptop work.
>
> Patches 4-6 are the BDW bits, but I also haven't tested them since the last
> rebase, and there's the possibility that something is still missing. I wouldn't
> recommend applying this to production trees yet, but I would recommend you to
> apply, test the patches and report the results to me!
>
> More importantly, the basic reason why I sent this series to the list is that if
> someone wants to add runtime PM support to some other platform (BYT anyone?),

Yea, I'm trying right now to enable this on top of this patchset.

> they should really try to base their patches on top of these. And they should
> really look at the SNB patch to have some idea on what they need to do first.
>
> Q: Why don't we have IVB runtime PM support?
> A: Just because it was easier for me to do development and test on a SNB
> machine. I really expect that IVB runtime PM will just reuse the SNB bits.
> The only thing missing for IVB is probably just a few "IS_IVYBRIDGE()" calls,
> and a call to modeset_update_crtc_power_domains(). I can provide a patch for
> this later.
>
> Thanks,
> Paulo
>
> Paulo Zanoni (6):
> drm/i915: kill dev_priv->pm.regsave
> drm/i915: add gen-specific runtime suspend/resume functions
> drm/i915: add SNB runtime PM support
> drm/i915: remove HAS_PC8 check
> drm/i915: BDW needs D_COMP writes through MCHBAR
> drm/i915: add BDW runtime PM support

These all have now a r-b from me, except the SNB one. That one looks ok
too, but I'd need some clarification on the context save/restore
semantics.

--Imre

> drivers/gpu/drm/i915/i915_drv.c | 53 ++++++++++++++++++++----
> drivers/gpu/drm/i915/i915_drv.h | 16 ++------
> drivers/gpu/drm/i915/i915_irq.c | 79 +++++-------------------------------
> drivers/gpu/drm/i915/intel_display.c | 43 ++++++++++++--------
> drivers/gpu/drm/i915/intel_drv.h | 4 +-
> 5 files changed, 87 insertions(+), 108 deletions(-)
>

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org