Re: [PATCH v5] drm/i915/vlv: WA for Turbo and RC6 to work together.

Deepak S
2014-03-30T06:27:55Z

On Friday 28 March 2014 06:36 PM, Chris Wilson wrote:
> On Fri, Mar 28, 2014 at 02:53:48PM +0200, Ville Syrjälä wrote:
>> On Thu, Mar 27, 2014 at 12:05:01PM +0530, deepak.s@linux.intel.com wrote:
>>> @@ -1403,6 +1411,13 @@ typedef struct drm_i915_private {
>>> /* gen6+ rps state */
>>> struct intel_gen6_power_mgmt rps;
>>>
>>> + /* rps wa up ei calculation */
>>> + struct intel_rps_ei_calc rps_up_ei;
>>> +
>>> + /* rps wa down ei calculation */
>>> + struct intel_rps_ei_calc rps_down_ei;
> I could have sworn there was a field for holding all the interesting rps
> state together.
> -Chris
>
Hi Chris,

Earlier i was using the rps structure to hold the wa rps state, but there was not of duplicated code to avoid that i created a separate structure.
We can still re-factor and use rps structure to hold the wa state. Let me know if we need to created a separate patch to re-factor or add to the WA patch itself.

I a thinking of adding a new patch on top this.

Thanks