From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 09/16] drm/i915: make intel_aux_display_runtime_get get runtime PM, not PC8 Date: Wed, 19 Mar 2014 17:23:39 +0200 Message-ID: <1395242619.1887.9.camel@intelbox> References: <1394233699-3741-1-git-send-email-przanoni@gmail.com> <1394233699-3741-10-git-send-email-przanoni@gmail.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1266223556==" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 4766E900C1 for ; Wed, 19 Mar 2014 08:29:02 -0700 (PDT) In-Reply-To: <1394233699-3741-10-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org --===============1266223556== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-jCnu104u+ZMqP2sR8/vc" --=-jCnu104u+ZMqP2sR8/vc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2014-03-07 at 20:08 -0300, Paulo Zanoni wrote: > From: Paulo Zanoni >=20 > Because we merged the PC8 and runtime PM features, so calling > intel_runtime_pm_get now has the same meaning, and we plan to just > remove hsw_disable_package_c8 for this exact reason. >=20 > My first patch tried to completely kill > intel_aux_display_runtime_get/put, because I was assuming that whoever > needed more than just runtime PM would have to get the appropriate > power domain instead of that, but it seems some people still want the > intel_aux_display_runtime_get abstraction, so keep it until someone > else tries to replace it with the more-standard power domain calls. >=20 > Signed-off-by: Paulo Zanoni Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/intel_pm.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel= _pm.c > index 550491e..8df5f8f 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -5888,15 +5888,14 @@ void intel_power_domains_init_hw(struct drm_i915_= private *dev_priv) > intel_power_domains_resume(dev_priv); > } > =20 > -/* Disables PC8 so we can use the GMBUS and DP AUX interrupts. */ > void intel_aux_display_runtime_get(struct drm_i915_private *dev_priv) > { > - hsw_disable_package_c8(dev_priv); > + intel_runtime_pm_get(dev_priv); > } > =20 > void intel_aux_display_runtime_put(struct drm_i915_private *dev_priv) > { > - hsw_enable_package_c8(dev_priv); > + intel_runtime_pm_put(dev_priv); > } > =20 > void intel_runtime_pm_get(struct drm_i915_private *dev_priv) --=-jCnu104u+ZMqP2sR8/vc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTKbZ7AAoJEORIIAnNuWDFh6QIALRR0Pho5RwpBvhQkMvjQiMS +iw0zTmPsUI6amN1GZ16dzj8mQLmKz3TvN7rnXKG5K5SGZ361sUYyuYpRokE66dg lq+Ilk1zHKC99NsxiQ1f386zD+ZUabvnwgNLw3E0jjY13DsCKUCO0fvuRvOlCVzl dL01RO2p1pKPMSZfidHkAMbThZ2FNtgSEL0dkmSdWlmkXipQw0Qq54vak9FYDmif l8pvCVy+AUPF9ioGLQlqDpEZFO6eS6pdN02bzCp3bwfd/R73sjVJn8nqdFZIkjiG 1oF87PR3qlHJXlSIjKeH+cFWILk8k7XnqaBJ1l/4/yJnkNu56XtA1CmCdP3t7/Y= =sH5L -----END PGP SIGNATURE----- --=-jCnu104u+ZMqP2sR8/vc-- --===============1266223556== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1266223556==--