From: sourab.gupta@intel.com
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Akash Goel <akash.goel@intel.com>,
Sourab Gupta <sourab.gupta@intel.com>
Subject: [PATCH v2] drm/i915/vlv: Enabling the TLB invalidate bit in GFX Mode register
Date: Fri, 21 Mar 2014 20:58:08 +0530 [thread overview]
Message-ID: <1395415688-12474-1-git-send-email-sourab.gupta@intel.com> (raw)
In-Reply-To: <20140321134534.GD18789@nuc-i3427.alporthouse.com>
From: Akash Goel <akash.goel@intel.com>
This patch Enables the bit for TLB invalidate in GFX Mode register.
According to bspec, When enabled this bit limits the invalidation
of the TLB only to batch buffer boundaries, to pipe_control
commands which have the TLB invalidation bit set and sync flushes.
If disabled, the TLB caches are flushed for every full flush of
the pipeline.
v2: Explicitly enabling TLB invalidate bit instead of assuming
default 1 (Chris Wilson)
Signed-off-by: Akash Goel <akash.goel@intel.com>
Signed-off-by: Sourab Gupta <sourab.gupta@intel.com>
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 4eb3e06..dca8c6d 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -583,10 +583,17 @@ static int init_render_ring(struct intel_ring_buffer *ring)
I915_WRITE(GFX_MODE,
_MASKED_BIT_ENABLE(GFX_TLB_INVALIDATE_ALWAYS));
- if (IS_GEN7(dev))
- I915_WRITE(GFX_MODE_GEN7,
- _MASKED_BIT_DISABLE(GFX_TLB_INVALIDATE_ALWAYS) |
- _MASKED_BIT_ENABLE(GFX_REPLAY_MODE));
+ if (IS_GEN7(dev)) {
+ if (IS_VALLEYVIEW(dev)) {
+ /* FIXME, should also apply to ivb */
+ I915_WRITE(GFX_MODE_GEN7,
+ _MASKED_BIT_ENABLE(GFX_TLB_INVALIDATE_ALWAYS) |
+ _MASKED_BIT_ENABLE(GFX_REPLAY_MODE));
+ } else
+ I915_WRITE(GFX_MODE_GEN7,
+ _MASKED_BIT_DISABLE(GFX_TLB_INVALIDATE_ALWAYS) |
+ _MASKED_BIT_ENABLE(GFX_REPLAY_MODE));
+ }
if (INTEL_INFO(dev)->gen >= 5) {
ret = init_pipe_control(ring);
--
1.8.5.1
next prev parent reply other threads:[~2014-03-21 15:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 12:22 [PATCH v2 0/3] Rendering specific Hw workarounds for VLV akash.goel
2014-02-07 12:22 ` [PATCH v2 1/3] drm/i915/vlv: Added a rendering specific Hw WA 'WaTlbInvalidateStoreDataBefore' akash.goel
2014-03-21 11:50 ` Gupta, Sourab
2014-03-21 11:59 ` Damien Lespiau
2014-02-07 12:22 ` [PATCH v2 2/3] drm/i915/vlv: Added a rendering specific Hw WA 'WaReadAfterWriteHazard' akash.goel
2014-02-07 12:22 ` [PATCH v2 3/3] drm/i915/vlv: Modified the programming of 2 regs in Ring initialisation akash.goel
2014-02-07 12:31 ` Chris Wilson
2014-02-07 14:34 ` Goel, Akash
2014-03-21 12:35 ` [PATCH 1/2] drm/i915/vlv: Remove the enabling of VS_TIMER_DISPATCH bit in MI MODE reg sourab.gupta
2014-03-21 12:35 ` [PATCH 2/2] drm/i915/vlv: Enabling the TLB invalidate bit in GFX Mode register sourab.gupta
2014-03-21 12:58 ` Chris Wilson
2014-03-21 13:09 ` Gupta, Sourab
2014-03-21 13:17 ` Chris Wilson
2014-03-21 13:31 ` Gupta, Sourab
2014-03-21 13:45 ` Chris Wilson
2014-03-21 15:28 ` sourab.gupta [this message]
2014-03-21 16:52 ` [PATCH v2] " Chris Wilson
2014-03-22 4:25 ` Gupta, Sourab
2014-03-22 9:20 ` Chris Wilson
2014-02-07 14:44 ` [PATCH v2 3/3] drm/i915/vlv: Modified the programming of 2 regs in Ring initialisation Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395415688-12474-1-git-send-email-sourab.gupta@intel.com \
--to=sourab.gupta@intel.com \
--cc=akash.goel@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox