From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 1/3] drm/i915: Don't set mode_config's cursor size Date: Tue, 25 Mar 2014 17:11:17 +0200 Message-ID: <1395760277.3271.1.camel@intelbox> References: <1395758972-31316-1-git-send-email-damien.lespiau@intel.com> <1395758972-31316-2-git-send-email-damien.lespiau@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0732141354==" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D34F6E368 for ; Tue, 25 Mar 2014 08:16:40 -0700 (PDT) In-Reply-To: <1395758972-31316-2-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org, Sagar Kamble List-Id: intel-gfx@lists.freedesktop.org --===============0732141354== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-s5DLNb9u83nnlmUo/W1l" --=-s5DLNb9u83nnlmUo/W1l Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2014-03-25 at 14:49 +0000, Damien Lespiau wrote: > Those fields are supposed to be a good default value for the cursor > size, intended for the case where the hardware doesn't support 64x64 > cursors, for use with a hw agnostic DDX driver for instance. >=20 > We're fine with 64x64 cursors though and don't need to set those fields > (DRM core will return 64 is we don't). If we declare 256x256, that > generic driver will use a big buffer for the cursor, without any good > reason. >=20 > Cc: Sagar Kamble > Cc: Imre Deak > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/intel_display.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/= intel_display.c > index 80dd1c2..7a47657 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -10557,8 +10557,6 @@ static void intel_crtc_init(struct drm_device *de= v, int pipe) > intel_crtc->max_cursor_width =3D CURSOR_WIDTH; > intel_crtc->max_cursor_height =3D CURSOR_HEIGHT; > } > - dev->mode_config.cursor_width =3D intel_crtc->max_cursor_width; > - dev->mode_config.cursor_height =3D intel_crtc->max_cursor_height; I thought drm_getcap should return the max cursor size, using these two fields. --Imre > =20 > drm_mode_crtc_set_gamma_size(&intel_crtc->base, 256); > for (i =3D 0; i < 256; i++) { --=-s5DLNb9u83nnlmUo/W1l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTMZyVAAoJEORIIAnNuWDFrHAIAOcBLC5Cpg/Z+qMuM6vN1OkG qJIT6tPyJ8Fy9m5Ftk0cmEpQffDc65+TsZG4QnnlzZl4WjLMSmcpw4qZ0CaXCUHL wF6Q1XHl0BIG53UvS+HmB8igwEsQigyx+KIWmeMaaKoJfsh7ZIjk89kkY+PYgLMw 4h7s8OjYerdxTg9s/52f27/iZtODqoE0mPekEVEXutpxVbMdRWJFsRaFGLkQxF4A PSU8D2Lx4FlgPqVfNCsKfhl+iA1nCA5VnEs/Gz+WokSVFnL27ZI5Kv8TB8Xzu7q+ AKCFRpJ8Ax9t1rKvAWTETzvIUrem8NmMx1aaQEeAD5hz93r4v2VhCbt/wCRztb0= =mQo9 -----END PGP SIGNATURE----- --=-s5DLNb9u83nnlmUo/W1l-- --===============0732141354== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0732141354==--