From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 6/6] drm/i915: add BDW runtime PM support Date: Tue, 01 Apr 2014 18:51:39 +0300 Message-ID: <1396367499.18070.47.camel@intelbox> References: <1394233957-3904-1-git-send-email-przanoni@gmail.com> <1394233957-3904-7-git-send-email-przanoni@gmail.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2117082915==" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 8ECB06E559 for ; Tue, 1 Apr 2014 09:00:31 -0700 (PDT) In-Reply-To: <1394233957-3904-7-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org --===============2117082915== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-omhp5Eg9aXuuhcetvGAf" --=-omhp5Eg9aXuuhcetvGAf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2014-03-07 at 20:12 -0300, Paulo Zanoni wrote: > From: Paulo Zanoni >=20 > This sould be enough. >=20 > v2: BDW should also run hsw_runtime_resume (Ben). >=20 > Signed-off-by: Paulo Zanoni Looks good, Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/i915_drv.c | 8 ++++++-- > drivers/gpu/drm/i915/i915_drv.h | 3 ++- > 2 files changed, 8 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_= drv.c > index 55f0181..2dcbbc0 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -874,8 +874,10 @@ static int intel_runtime_suspend(struct device *devi= ce) > =20 > if (IS_GEN6(dev)) > snb_runtime_suspend(dev_priv); > - else if (IS_HASWELL(dev)) > + else if (IS_HASWELL(dev) || IS_BROADWELL(dev)) > hsw_runtime_suspend(dev_priv); > + else > + WARN_ON(1); > =20 > i915_gem_release_all_mmaps(dev_priv); > =20 > @@ -910,8 +912,10 @@ static int intel_runtime_resume(struct device *devic= e) > =20 > if (IS_GEN6(dev)) > snb_runtime_resume(dev_priv); > - else if (IS_HASWELL(dev)) > + else if (IS_HASWELL(dev) || IS_BROADWELL(dev)) > hsw_runtime_resume(dev_priv); > + else > + WARN_ON(1); > =20 > DRM_DEBUG_KMS("Device resumed\n"); > return 0; > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_= drv.h > index 1debc412..2f7246a 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -1997,7 +1997,8 @@ struct drm_i915_cmd_table { > #define HAS_DDI(dev) (INTEL_INFO(dev)->has_ddi) > #define HAS_FPGA_DBG_UNCLAIMED(dev) (INTEL_INFO(dev)->has_fpga_dbg) > #define HAS_PSR(dev) (IS_HASWELL(dev) || IS_BROADWELL(dev)) > -#define HAS_RUNTIME_PM(dev) (IS_GEN6(dev) || IS_HASWELL(dev)) > +#define HAS_RUNTIME_PM(dev) (IS_GEN6(dev) || IS_HASWELL(dev) || \ > + IS_BROADWELL(dev)) > =20 > #define INTEL_PCH_DEVICE_ID_MASK 0xff00 > #define INTEL_PCH_IBX_DEVICE_ID_TYPE 0x3b00 --=-omhp5Eg9aXuuhcetvGAf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTOuCLAAoJEORIIAnNuWDFJVAIAOmtGfcTzaMJKNdGwLqGrA+Z H0g6y8l5qoL5HCGGZvqxvioXf7Gc8pn++yoD0/LOprnhHY9PDQlQ1O4ziii82sVa VFrSmNlmJmivrG6ZC7abJ5b6abvhAJ1ppDABuKSu84airXLwni3YY6pEP0vFxXjX b2rBwrf6BAgXwSMdJxbcKAG7xasj8TQNt0VBHglV2RibRi4trENpZKB8pKL9riaR 8DY53GlRmEspThCM0pCgwcHXpSXmG8ZNTO8G5qAV2F8vVBGNk7vSSV5gM8gH6VBW RR/DMnb9qWsr+0hlAQjl6/Amh//XsU3ojWKh+InvO+CEqYn37Q7iFWF/AEec21M= =nf2v -----END PGP SIGNATURE----- --=-omhp5Eg9aXuuhcetvGAf-- --===============2117082915== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2117082915==--