From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 0/6] SNB/BDW runtime PM Date: Tue, 01 Apr 2014 19:21:09 +0300 Message-ID: <1396369269.18070.55.camel@intelbox> References: <1394233957-3904-1-git-send-email-przanoni@gmail.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0831648577==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 407496E7A3 for ; Tue, 1 Apr 2014 09:21:14 -0700 (PDT) In-Reply-To: <1394233957-3904-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org --===============0831648577== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-SK3pzIJpwHMJQGBA+tCL" --=-SK3pzIJpwHMJQGBA+tCL Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2014-03-07 at 20:12 -0300, Paulo Zanoni wrote: > From: Paulo Zanoni >=20 > Hi >=20 > This series depends on: > - [PATCH 0/6] More runtime PM fixes > - [PATCH 00/16] Merge PC8 with runtime PM, v3 > - [PATCH 00/20] ILK+ interrupt improvements, v2 >=20 > Patches 1 and 2 are the last pieces of my runtime PM rework, and patch 1 = needs > all the previous patches to be merged before it can be merged. >=20 > Patch 3 adds runtime PM support to SNB. It's not widely tested and I have= n't > tested it for a while, but at some point this was all that was needed to = make my > SNB laptop work. >=20 > Patches 4-6 are the BDW bits, but I also haven't tested them since the la= st > rebase, and there's the possibility that something is still missing. I wo= uldn't > recommend applying this to production trees yet, but I would recommend yo= u to > apply, test the patches and report the results to me! >=20 > More importantly, the basic reason why I sent this series to the list is = that if > someone wants to add runtime PM support to some other platform (BYT anyon= e?), Yea, I'm trying right now to enable this on top of this patchset. > they should really try to base their patches on top of these. And they sh= ould > really look at the SNB patch to have some idea on what they need to do fi= rst. >=20 > Q: Why don't we have IVB runtime PM support? > A: Just because it was easier for me to do development and test on a SNB > machine. I really expect that IVB runtime PM will just reuse the SNB bits= . > The only thing missing for IVB is probably just a few "IS_IVYBRIDGE()" ca= lls, > and a call to modeset_update_crtc_power_domains(). I can provide a patch = for > this later. >=20 > Thanks, > Paulo >=20 > Paulo Zanoni (6): > drm/i915: kill dev_priv->pm.regsave > drm/i915: add gen-specific runtime suspend/resume functions > drm/i915: add SNB runtime PM support > drm/i915: remove HAS_PC8 check > drm/i915: BDW needs D_COMP writes through MCHBAR > drm/i915: add BDW runtime PM support These all have now a r-b from me, except the SNB one. That one looks ok too, but I'd need some clarification on the context save/restore semantics. --Imre > drivers/gpu/drm/i915/i915_drv.c | 53 ++++++++++++++++++++---- > drivers/gpu/drm/i915/i915_drv.h | 16 ++------ > drivers/gpu/drm/i915/i915_irq.c | 79 +++++-------------------------= ------ > drivers/gpu/drm/i915/intel_display.c | 43 ++++++++++++-------- > drivers/gpu/drm/i915/intel_drv.h | 4 +- > 5 files changed, 87 insertions(+), 108 deletions(-) >=20 --=-SK3pzIJpwHMJQGBA+tCL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTOud1AAoJEORIIAnNuWDF864H/iXmdNQ/vsFNNCCEDXTFEJKf SzGwy9exBPPWwiQKEI2BAq/L+1edNxz1irx4RKPAneboSvKMLTprJZ9keVweLYmD OTNymumLAJUdTEwXC5ChCnFH44NahtpHuZZUFBbcwWR6CMZeHKbtmVtz9pUg++UJ OrVvSP2P21v0Ku+KCRO43++GsuZMiSBxR/KtoSkfq2STmnLjLARbAotCiUmtgf3A j4iflgBrZr13RfMmRnTg4ywsRThbCUq81/Op+gA0TfIIhc1sbGgdPpIbuuKFoPEm jA7+AAWLfzsdCY9SknxCbppcJVYbKMDz+ndbUwxNIlHcIYoMe2PoOy/zBo0tCa0= =O2Kj -----END PGP SIGNATURE----- --=-SK3pzIJpwHMJQGBA+tCL-- --===============0831648577== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0831648577==--