From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 0/4] Reduce intel_display.c
Date: Wed, 9 Apr 2014 18:44:29 -0300 [thread overview]
Message-ID: <1397079873-18257-1-git-send-email-przanoni@gmail.com> (raw)
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
Hi
We always talk about how intel_display.c is a giant file and how we would like
to reduce it, so this is my attempt. Currently the file has 12090 lines, and
after my patch series it has 8850 lines.
I don't know if right now is the appropriate time to merge patches like this. I
don't remember seeing too many patches on the list touching cursor/fdi/eld/pll
functions, but I know there is never an appropriate time for huge changes.
Also, this change will obviously make the lives of people who backport our
patches more complicated. So if we don't want this series at all, feel free to
NACK it.
I also didn't really know what kind of changes I needed to do to the file
headers, so I just copied the header from intel_display.c, kept Eric's name and
added a "2014" to Intel's copyright. I am not a lawyer and this may be not the
best thing to do, so please tell me the correct approach here :)
There are also some things that we might want to migrate from intel_ddi.c to
intel_pll.c, but I'll leave this to another patch.
Also, feel free to propose better ways to split intel_display.c.
Thanks,
Paulo
Paulo Zanoni (4):
drm/i915: extract intel_eld.c from intel_display.c
drm/i915: extract intel_cursor.c from intel_display.c
drm/i915: extract intel_fdi.c from intel_display.c
drm/i915: extract intel_pll.c from intel_display.c
drivers/gpu/drm/i915/Makefile | 4 +
drivers/gpu/drm/i915/intel_cursor.c | 357 ++++
drivers/gpu/drm/i915/intel_ddi.c | 142 +-
drivers/gpu/drm/i915/intel_display.c | 3622 ++--------------------------------
drivers/gpu/drm/i915/intel_drv.h | 143 +-
drivers/gpu/drm/i915/intel_eld.c | 355 ++++
drivers/gpu/drm/i915/intel_fdi.c | 959 +++++++++
drivers/gpu/drm/i915/intel_panel.c | 36 +
drivers/gpu/drm/i915/intel_pll.c | 1779 +++++++++++++++++
9 files changed, 3808 insertions(+), 3589 deletions(-)
create mode 100644 drivers/gpu/drm/i915/intel_cursor.c
create mode 100644 drivers/gpu/drm/i915/intel_eld.c
create mode 100644 drivers/gpu/drm/i915/intel_fdi.c
create mode 100644 drivers/gpu/drm/i915/intel_pll.c
--
1.9.0
next reply other threads:[~2014-04-09 21:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 21:44 Paulo Zanoni [this message]
2014-04-09 21:44 ` [PATCH 1/4] drm/i915: extract intel_eld.c from intel_display.c Paulo Zanoni
2014-04-09 21:44 ` [PATCH 2/4] drm/i915: extract intel_cursor.c " Paulo Zanoni
2014-04-09 21:44 ` [PATCH 3/4] drm/i915: extract intel_fdi.c " Paulo Zanoni
2014-04-09 21:44 ` [PATCH 4/4] drm/i915: extract intel_pll.c " Paulo Zanoni
2014-04-09 21:49 ` [PATCH 0/4] Reduce intel_display.c Eric Anholt
2014-04-11 6:59 ` Ben Widawsky
2014-04-11 7:21 ` Jani Nikula
2014-04-15 19:25 ` Daniel Vetter
2014-04-16 16:37 ` Ville Syrjälä
2014-04-16 16:47 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397079873-18257-1-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox