Re: [PATCH] drm/i915/SDVO: For sysfs link put directory and target in correct order

[Imre Deak <imre.deak@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1370 bytes --]

On Fri, 2014-04-11 at 19:07 +0200, Egbert Eich wrote:
> When linking the i2c sysfs file into the connector's directory
> pass directory and link target in the right order.
> This code was introduced with:
> 
>   commit 931c1c26983b4f84e33b78579fc8d57e4a14c6b4
>   Author: Imre Deak <imre.deak@intel.com>
>   Date:   Tue Feb 11 17:12:51 2014 +0200
> 
>     drm/i915: sdvo: add i2c sysfs symlink to the connector's directory
> 
>     This is the same what we do for DP connectors, so make things more
>     consistent.
> 
> Signed-off-by: Egbert Eich <eich@suse.de>

Oops, good catch. The fix looks ok, fwiw:
Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_sdvo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
> index 5043f16..2d4d461 100644
> --- a/drivers/gpu/drm/i915/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> @@ -2428,8 +2428,8 @@ intel_sdvo_connector_init(struct intel_sdvo_connector *connector,
>  	if (ret < 0)
>  		goto err1;
>  
> -	ret = sysfs_create_link(&encoder->ddc.dev.kobj,
> -				&drm_connector->kdev->kobj,
> +	ret = sysfs_create_link(&drm_connector->kdev->kobj,
> +				&encoder->ddc.dev.kobj,
>  				encoder->ddc.dev.kobj.name);
>  	if (ret < 0)
>  		goto err2;


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx