From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915/SDVO: For sysfs link put directory and target in correct order Date: Fri, 11 Apr 2014 20:26:25 +0300 Message-ID: <1397237185.25357.8.camel@intelbox> References: <1397236064-19263-1-git-send-email-eich@suse.de> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0310979844==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 89DF16E40F for ; Fri, 11 Apr 2014 10:26:28 -0700 (PDT) In-Reply-To: <1397236064-19263-1-git-send-email-eich@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Egbert Eich Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0310979844== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-Z+q8s4lgkGIQm9zYqzAr" --=-Z+q8s4lgkGIQm9zYqzAr Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2014-04-11 at 19:07 +0200, Egbert Eich wrote: > When linking the i2c sysfs file into the connector's directory > pass directory and link target in the right order. > This code was introduced with: >=20 > commit 931c1c26983b4f84e33b78579fc8d57e4a14c6b4 > Author: Imre Deak > Date: Tue Feb 11 17:12:51 2014 +0200 >=20 > drm/i915: sdvo: add i2c sysfs symlink to the connector's directory >=20 > This is the same what we do for DP connectors, so make things more > consistent. >=20 > Signed-off-by: Egbert Eich Oops, good catch. The fix looks ok, fwiw: Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/intel_sdvo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/int= el_sdvo.c > index 5043f16..2d4d461 100644 > --- a/drivers/gpu/drm/i915/intel_sdvo.c > +++ b/drivers/gpu/drm/i915/intel_sdvo.c > @@ -2428,8 +2428,8 @@ intel_sdvo_connector_init(struct intel_sdvo_connect= or *connector, > if (ret < 0) > goto err1; > =20 > - ret =3D sysfs_create_link(&encoder->ddc.dev.kobj, > - &drm_connector->kdev->kobj, > + ret =3D sysfs_create_link(&drm_connector->kdev->kobj, > + &encoder->ddc.dev.kobj, > encoder->ddc.dev.kobj.name); > if (ret < 0) > goto err2; --=-Z+q8s4lgkGIQm9zYqzAr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTSCXBAAoJEORIIAnNuWDFqzcH/1NwaSEhC21tWBMkPkzFqrs4 EEhj+qNe+McqtXv33+0mu7dThQgVjxmGQICedxwE+5abdzIXQYB/5xhc9lKjMwVL rz9NkLIyVO8YA7Z8vJIDacVwNwRdhbG+ikmKuuZGWDNTnTTUVgX09F7L8E4YtAM0 jm1ckGOW3Ggoux3NiIOBst9ysrSX0Iqy4ZPOkHi2fnrVRx+QbfqdMqlQtEhP1zsN awgBeos3vWYWN71w53vyihSRGnu149rXClsdkKmzKGHIELmMz4iFul3mHqnYdbjL vbU8jyYYMhI0duuU1RyF+h6VV5Mhn+nt5Qt+Fbu40OmApwKAjIOjYJfQ/ZSBW88= =gDyg -----END PGP SIGNATURE----- --=-Z+q8s4lgkGIQm9zYqzAr-- --===============0310979844== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0310979844==--