From: Shobhit Kumar <shobhit.kumar@intel.com>
To: intel-gfx <intel-gfx@lists.freedesktop.org>
Cc: Jani Nikula <jani.nikula@intel.com>,
Daniel Vetter <daniel.vetter@intel.com>,
arjan.van.de.ven@intel.com
Subject: [PATCH 1/4] drm/i915: Correct MIPI operation mode as per expected values from VBT
Date: Mon, 14 Apr 2014 11:18:24 +0530 [thread overview]
Message-ID: <1397454507-10273-2-git-send-email-shobhit.kumar@intel.com> (raw)
In-Reply-To: <1397454507-10273-1-git-send-email-shobhit.kumar@intel.com>
In VBT fields operation mode is 0 for Video mode and 1 for command mode.
This field will be directly used as is in generic panel driver. So
adjust accordingly.
Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
---
drivers/gpu/drm/i915/intel_drv.h | 4 ++--
drivers/gpu/drm/i915/intel_dsi.c | 4 ++--
drivers/gpu/drm/i915/intel_dsi.h | 4 +++-
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index c551472..fca11f3 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -106,8 +106,8 @@
#define INTEL_DVO_CHIP_TMDS 2
#define INTEL_DVO_CHIP_TVOUT 4
-#define INTEL_DSI_COMMAND_MODE 0
-#define INTEL_DSI_VIDEO_MODE 1
+#define INTEL_DSI_VIDEO_MODE 0
+#define INTEL_DSI_COMMAND_MODE 1
struct intel_framebuffer {
struct drm_framebuffer base;
diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 4e271c7..2795782 100644
--- a/drivers/gpu/drm/i915/intel_dsi.c
+++ b/drivers/gpu/drm/i915/intel_dsi.c
@@ -59,12 +59,12 @@ static struct intel_dsi *intel_attached_dsi(struct drm_connector *connector)
static inline bool is_vid_mode(struct intel_dsi *intel_dsi)
{
- return intel_dsi->dev.type == INTEL_DSI_VIDEO_MODE;
+ return intel_dsi->operation_mode == INTEL_DSI_VIDEO_MODE;
}
static inline bool is_cmd_mode(struct intel_dsi *intel_dsi)
{
- return intel_dsi->dev.type == INTEL_DSI_COMMAND_MODE;
+ return intel_dsi->operation_mode == INTEL_DSI_COMMAND_MODE;
}
static void intel_dsi_hot_plug(struct intel_encoder *encoder)
diff --git a/drivers/gpu/drm/i915/intel_dsi.h b/drivers/gpu/drm/i915/intel_dsi.h
index 550714c..1649422 100644
--- a/drivers/gpu/drm/i915/intel_dsi.h
+++ b/drivers/gpu/drm/i915/intel_dsi.h
@@ -31,7 +31,6 @@
struct intel_dsi_device {
unsigned int panel_id;
const char *name;
- int type;
const struct intel_dsi_dev_ops *dev_ops;
void *dev_priv;
};
@@ -85,6 +84,9 @@ struct intel_dsi {
/* virtual channel */
int channel;
+ /* Video mode or command mode */
+ u16 operation_mode;
+
/* number of DSI lanes */
unsigned int lane_count;
--
1.8.3.2
next prev parent reply other threads:[~2014-04-14 5:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 5:48 [PATCH 0/4] Generic MIPI Panel driver Shobhit Kumar
2014-04-14 5:48 ` Shobhit Kumar [this message]
2014-05-15 15:03 ` [PATCH 1/4] drm/i915: Correct MIPI operation mode as per expected values from VBT Damien Lespiau
2014-04-14 5:48 ` [PATCH 2/4] drm/i915: MIPI init count programming as generic parameter Shobhit Kumar
2014-05-15 15:04 ` Damien Lespiau
2014-04-14 5:48 ` [PATCH 3/4] drm/i915: MIPI PPS delays added Shobhit Kumar
2014-05-15 15:06 ` Damien Lespiau
2014-05-15 20:44 ` Daniel Vetter
2014-04-14 5:48 ` [PATCH 4/4] drm/i915: Add support for Generic MIPI panel driver Shobhit Kumar
2014-05-15 16:48 ` Damien Lespiau
2014-05-16 9:23 ` Shobhit Kumar
2014-05-16 11:17 ` Damien Lespiau
2014-05-19 14:23 ` Damien Lespiau
2014-05-20 16:16 ` Shobhit Kumar
2014-05-20 20:55 ` Damien Lespiau
2014-05-22 7:45 ` Kumar, Shobhit
2014-05-23 16:05 ` [v2] " Shobhit Kumar
2014-05-27 11:02 ` Damien Lespiau
2014-05-27 11:21 ` Kumar, Shobhit
2014-05-27 11:37 ` Daniel Vetter
2014-05-27 11:39 ` Daniel Vetter
2014-05-27 11:42 ` Kumar, Shobhit
2014-05-27 11:51 ` Daniel Vetter
2014-05-27 12:26 ` Damien Lespiau
2014-05-27 13:53 ` [PATCH] drm/i915: Fix checkpatch errors Shobhit Kumar
2014-05-27 14:19 ` Damien Lespiau
2014-05-27 14:34 ` Kumar, Shobhit
2014-05-27 14:39 ` Damien Lespiau
2014-05-27 17:03 ` Daniel Vetter
2014-04-28 4:16 ` [PATCH 0/4] Generic MIPI Panel driver Kumar, Shobhit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397454507-10273-2-git-send-email-shobhit.kumar@intel.com \
--to=shobhit.kumar@intel.com \
--cc=arjan.van.de.ven@intel.com \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox