public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Shobhit Kumar <shobhit.kumar@intel.com>
To: intel-gfx <intel-gfx@lists.freedesktop.org>
Cc: Jani Nikula <jani.nikula@intel.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	arjan.van.de.ven@intel.com
Subject: [PATCH 3/4] drm/i915: MIPI PPS delays added
Date: Mon, 14 Apr 2014 11:18:26 +0530	[thread overview]
Message-ID: <1397454507-10273-4-git-send-email-shobhit.kumar@intel.com> (raw)
In-Reply-To: <1397454507-10273-1-git-send-email-shobhit.kumar@intel.com>

Added as generic parameters which will be initialized in the panel
driver and are specific to panels.

Backlight delays have also kept as placeholders and will be used used
once we have MIPI backlight enabling support

Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
---
 drivers/gpu/drm/i915/intel_dsi.c | 5 +++++
 drivers/gpu/drm/i915/intel_dsi.h | 7 +++++++
 2 files changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 09b9318..0d4dd54 100644
--- a/drivers/gpu/drm/i915/intel_dsi.c
+++ b/drivers/gpu/drm/i915/intel_dsi.c
@@ -185,6 +185,8 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder)
 	/* put device in ready state */
 	intel_dsi_device_ready(encoder);
 
+	msleep(intel_dsi->panel_on_delay);
+
 	if (intel_dsi->dev.dev_ops->panel_reset)
 		intel_dsi->dev.dev_ops->panel_reset(&intel_dsi->dev);
 
@@ -301,6 +303,9 @@ static void intel_dsi_post_disable(struct intel_encoder *encoder)
 
 	if (intel_dsi->dev.dev_ops->disable_panel_power)
 		intel_dsi->dev.dev_ops->disable_panel_power(&intel_dsi->dev);
+
+	msleep(intel_dsi->panel_off_delay);
+	msleep(intel_dsi->panel_pwr_cycle_delay);
 }
 
 static bool intel_dsi_get_hw_state(struct intel_encoder *encoder,
diff --git a/drivers/gpu/drm/i915/intel_dsi.h b/drivers/gpu/drm/i915/intel_dsi.h
index be132c5..e3f4e91 100644
--- a/drivers/gpu/drm/i915/intel_dsi.h
+++ b/drivers/gpu/drm/i915/intel_dsi.h
@@ -116,6 +116,13 @@ struct intel_dsi {
 	u16 clk_hs_to_lp_count;
 
 	u16 init_count;
+
+	/* all delays in ms */
+	u16 backlight_off_delay;
+	u16 backlight_on_delay;
+	u16 panel_on_delay;
+	u16 panel_off_delay;
+	u16 panel_pwr_cycle_delay;
 };
 
 static inline struct intel_dsi *enc_to_intel_dsi(struct drm_encoder *encoder)
-- 
1.8.3.2

  parent reply	other threads:[~2014-04-14  5:48 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-14  5:48 [PATCH 0/4] Generic MIPI Panel driver Shobhit Kumar
2014-04-14  5:48 ` [PATCH 1/4] drm/i915: Correct MIPI operation mode as per expected values from VBT Shobhit Kumar
2014-05-15 15:03   ` Damien Lespiau
2014-04-14  5:48 ` [PATCH 2/4] drm/i915: MIPI init count programming as generic parameter Shobhit Kumar
2014-05-15 15:04   ` Damien Lespiau
2014-04-14  5:48 ` Shobhit Kumar [this message]
2014-05-15 15:06   ` [PATCH 3/4] drm/i915: MIPI PPS delays added Damien Lespiau
2014-05-15 20:44     ` Daniel Vetter
2014-04-14  5:48 ` [PATCH 4/4] drm/i915: Add support for Generic MIPI panel driver Shobhit Kumar
2014-05-15 16:48   ` Damien Lespiau
2014-05-16  9:23     ` Shobhit Kumar
2014-05-16 11:17     ` Damien Lespiau
2014-05-19 14:23   ` Damien Lespiau
2014-05-20 16:16     ` Shobhit Kumar
2014-05-20 20:55       ` Damien Lespiau
2014-05-22  7:45         ` Kumar, Shobhit
2014-05-23 16:05   ` [v2] " Shobhit Kumar
2014-05-27 11:02     ` Damien Lespiau
2014-05-27 11:21       ` Kumar, Shobhit
2014-05-27 11:37         ` Daniel Vetter
2014-05-27 11:39         ` Daniel Vetter
2014-05-27 11:42           ` Kumar, Shobhit
2014-05-27 11:51             ` Daniel Vetter
2014-05-27 12:26               ` Damien Lespiau
2014-05-27 13:53               ` [PATCH] drm/i915: Fix checkpatch errors Shobhit Kumar
2014-05-27 14:19                 ` Damien Lespiau
2014-05-27 14:34                   ` Kumar, Shobhit
2014-05-27 14:39                     ` Damien Lespiau
2014-05-27 17:03                       ` Daniel Vetter
2014-04-28  4:16 ` [PATCH 0/4] Generic MIPI Panel driver Kumar, Shobhit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397454507-10273-4-git-send-email-shobhit.kumar@intel.com \
    --to=shobhit.kumar@intel.com \
    --cc=arjan.van.de.ven@intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox