From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH V3 4/6] drm/i915:Add the VCS2 switch in Intel_ring_setup_status_page for Gen7 to remove the switch check warning Date: Wed, 16 Apr 2014 19:43:57 +0300 Message-ID: <1397666637.4215.46.camel@intelbox> References: <1397616077-1125-1-git-send-email-yakui.zhao@intel.com> <1397616077-1125-5-git-send-email-yakui.zhao@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1371454051==" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 5510D6E3E9 for ; Wed, 16 Apr 2014 09:44:14 -0700 (PDT) In-Reply-To: <1397616077-1125-5-git-send-email-yakui.zhao@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Zhao Yakui Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1371454051== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-9XisGEtBcyvb91dnfvp6" --=-9XisGEtBcyvb91dnfvp6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2014-04-16 at 10:41 +0800, Zhao Yakui wrote: > The Gen7 doesn't have the second BSD ring. But it will complain the switc= h check > warning message during compilation. So just add it to remove the > switch check warning. >=20 > V1->V2: Follow Daniel's comment to update the comment >=20 > Signed-off-by: Zhao Yakui > --- > drivers/gpu/drm/i915/intel_ringbuffer.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i9= 15/intel_ringbuffer.c > index 8b9b89080..2c89525 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -988,6 +988,11 @@ void intel_ring_setup_status_page(struct intel_ring_= buffer *ring) > case BCS: > mmio =3D BLT_HWS_PGA_GEN7; > break; > + /* > + * VCS2 actually doesn't exist on Gen7. Only shut up > + * gcc switch check warning > + */ > + case VCS2: A WARN would've been better here, but in any case: Reviewed-by: Imre Deak > case VCS: > mmio =3D BSD_HWS_PGA_GEN7; > break; --=-9XisGEtBcyvb91dnfvp6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTTrNNAAoJEORIIAnNuWDFQSgH/0C7gsKzweVCdEn5KAmcCtBE zvEdJstqwi6kuBHzfyE6x27OQ2AXU7PiH3pIQ6fMcir8tA8w7V4MPXYBMiwxdOL+ 3dpAqdQwfiI3Or48IoGJnYiuD6GhRI+uN7olDrC7dv1VmKRreOJl+spbZ/WIGoMH zNyVBRdznHXXGz2MlJ9oqcWwYP5LikoNoRZWt2e2DfIyd2Kp5D6BXyM6u8AUTBLL B94j9rSXaDPW1SjmClpgUQY8d+SHb4ZT+8Q58CCR9RnwDdhTTfGZ/dE5NyNM0tCp AjcMxGbEyuDUCe5J7xG20d6dnm6RXVktXFmry9zSml6oiOJRiVZc1jXfZ1SPliA= =LMS/ -----END PGP SIGNATURE----- --=-9XisGEtBcyvb91dnfvp6-- --===============1371454051== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1371454051==--