From mboxrd@z Thu Jan  1 00:00:00 1970
From: Imre Deak <imre.deak@intel.com>
Subject: Re: [PATCH] Revert "drm/i915: fix infinite loop at
 gen6_update_ring_freq"
Date: Mon, 28 Apr 2014 22:54:21 +0300
Message-ID: <1398714861.3074.30.camel@ideak-mobl>
References: <1397113487-25717-1-git-send-email-daniel.vetter@ffwll.ch>
 <20140410175043.GB7294@bwidawsk.net> <20140410175226.GA8164@bwidawsk.net>
 <20140411090212.GZ9262@phenom.ffwll.local>
 <CA+gsUGRgjyL4RHXuxs4vqr6fucPyQi9ushfR0-n_J7xTtAqSkQ@mail.gmail.com>
 <20140423070506.GQ10722@phenom.ffwll.local>
 <CA+gsUGSZt_VosgboKw-TQDM1acQk=RYOp3M27c+kC-QqNPrhHg@mail.gmail.com>
 <CAKMK7uHBPGZkaXnHrBhcu8TRp__NkhiLzULiXVyStyFJw-P7vA@mail.gmail.com>
Reply-To: imre.deak@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id F34B06E2AB
 for <intel-gfx@lists.freedesktop.org>; Mon, 28 Apr 2014 12:54:25 -0700 (PDT)
In-Reply-To: <CAKMK7uHBPGZkaXnHrBhcu8TRp__NkhiLzULiXVyStyFJw-P7vA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Ben Widawsky <ben@bwidawsk.net>, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, 2014-04-28 at 21:23 +0200, Daniel Vetter wrote:
> On Mon, Apr 28, 2014 at 8:14 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> > This can probably be reproduced on non-BDW machines too, with RC6 disabled.
> 
> If I understand Imre's patch correctly the bug is that we didn't have
> rc6 on bdw, but the sanitize function didn't make this clear leading
> to bugs. 

Yes, that's correct. For runtime PM we require RC6 to be enabled, and we
use intel_enable_rc6() to check for this. Before patch [1]
intel_enable_rc6() reported incorrectly on BDW that RC6 is enabled.

--Imre

[1]
http://lists.freedesktop.org/archives/intel-gfx/2014-April/044354.html

>If my understanding is wrong the I need to drop Imre's patch again.

> -Daniel