From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915: remove user GTT mappings early during runtime suspend Date: Tue, 06 May 2014 14:42:26 +0300 Message-ID: <1399376546.19761.1.camel@intelbox> References: <1399375730-4355-1-git-send-email-imre.deak@intel.com> <20140506114011.GB7322@nuc-i3427.alporthouse.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0373003706==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F3C56EB10 for ; Tue, 6 May 2014 04:42:29 -0700 (PDT) In-Reply-To: <20140506114011.GB7322@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0373003706== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-zf2rAYVjKKOHZ2tuBgCn" --=-zf2rAYVjKKOHZ2tuBgCn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2014-05-06 at 12:40 +0100, Chris Wilson wrote: > On Tue, May 06, 2014 at 02:28:50PM +0300, Imre Deak wrote: > > Currently user space can access GEM buffers mapped to GTT through > > existing mappings concurrently while the platform specific suspend > > handlers are running. Since these handlers may change the HW state in = a > > way that would break such accesses, remove the mappings before calling > > the handlers. >=20 > Hmm, but you never locked the device, so what is preventing those > concurrent accesses from refaulting in GTT entires anyway. Please explain > the context under which the runtime suspend code executes, and leave > that explanation within easy reach of intel_runtime_suspend() - > preferrably with testing of those assumptions. During faulting we take an RPM reference, so that avoids concurrent re-faults. I could add a comment about this to the code. --Imre --=-zf2rAYVjKKOHZ2tuBgCn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTaMqiAAoJEORIIAnNuWDFfkEIANTaxRXXhIB5Ib5xy2ao4+dn pNYYT6xbhKzFwrP/whq8Qwo3je0HsEJ0hGdJPEcudh4BJ55QqQFBe2dlXMCfxX+K Ow+GU9iI+bqPnQ8el11y/Cm9b48HMh+shHgM8U/k+JIZ4VC83LhuuOuMgrA70c75 QXtdBsO+kW/8KyUlLS878FoYUCngg3oKHGyEuDaN1d7r9IDwrB0syRRQ2fVxH4pr /gETf8MgZiwCptteLNwgCQyuN++NZiLLtk9Xdsan+GOyLSydYobUlFwUU51jiMGU N4CHVdS7Y7Q4pTpKeocT3eCn20Z9QnfhoQ0KS+JXWo3JvzfCHITdCedVk8BQHOE= =mVPO -----END PGP SIGNATURE----- --=-zf2rAYVjKKOHZ2tuBgCn-- --===============0373003706== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0373003706==--