From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 1/2] drm/i915: fix possible RPM ref leaking during RPS disabling Date: Tue, 13 May 2014 16:56:26 +0300 Message-ID: <1399989386.5451.4.camel@intelbox> References: <1399908905-3025-1-git-send-email-imre.deak@intel.com> <20140512175157.GC25056@phenom.ffwll.local> <1399988770.5451.3.camel@intelbox> <20140513135440.GI3908@phenom.ffwll.local> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0456355509==" Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 752636EABD for ; Tue, 13 May 2014 06:57:06 -0700 (PDT) In-Reply-To: <20140513135440.GI3908@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0456355509== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-Ym35/rhkSLqa3r+SwvB/" --=-Ym35/rhkSLqa3r+SwvB/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2014-05-13 at 15:54 +0200, Daniel Vetter wrote: > On Tue, May 13, 2014 at 04:46:10PM +0300, Imre Deak wrote: > > On Mon, 2014-05-12 at 19:51 +0200, Daniel Vetter wrote: > > > On Mon, May 12, 2014 at 06:35:04PM +0300, Imre Deak wrote: > > > > In > > > >=20 > > > > commit c6df39b5ea6342323a42edfbeeca0a28c643d7ae > > > > Author: Imre Deak > > > > Date: Mon Apr 14 20:24:29 2014 +0300 > > > >=20 > > > > drm/i915: get a runtime PM ref for the deferred GT powersave en= abling > > > >=20 > > > > I added an RPM get-ref when enabling RPS from a deferred work, but = forgot > > > > to add the corresponding put-ref when canceling the work. This may = leave > > > > RPM disabled. > > > >=20 > > > > Signed-off-by: Imre Deak > > >=20 > > > Could we intentionally hit this by e.g. racing a suspend/resume again= st > > > runtime pm? E.g. > > > 1. disable all outputs, make sure we've entered runtime pm > > > 2. set runtime autosuspend delay to 0 > > > 3. suspend/resume > > > 4. autosuspend (hopefully, my understanding is a bit unclear) > > >=20 > > > ->Boom > > >=20 > > > Would look nice as an igt subtest if it works ;-) > >=20 > > Yep, works consistently as expected both before and after the fix. I > > pushed the new subtest, please add here: > > Testcase: igt/pm_pc8/system-suspend >=20 > Now I'm confused: I expected this to blow up without your fix here, and > not work with or without it?! Please unconfuse ... Blows up consistently before the fix and passes consistently after. --Imre > -Daniel --=-Ym35/rhkSLqa3r+SwvB/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTciSKAAoJEORIIAnNuWDFBM8IALk5n3O5tNHvGy9HpaD+HmSp 3OEnT2eqr8my+Rjc5X/NL5nMniboT5GUF+ZOR4j/7+QFEcrhxipDQoJPJrzglo0S zbsEV4+yAuyWGydV1rU5h/wDjOVzXCTqJ2yoARmxZpRsd6CdENp3gaZZ+DJ9zSGc 39EOCXaN4SSu9evlKMd+eyKlX4jjLBbCgzWiytXDLIZArOx3t6bpA0rBtarB+qkz TB8KuH5SLMzmdhYM0CX726aYIYJ848GqdrPx5ku8OtroNIzANwhgi5EZft2X9FgJ dqIM0kIIyZa3DlO3f0Di+u8P7V5nPdQHH5oTuUSEo+7IZmQsMBlGpcZfJGmhH/0= =q4bv -----END PGP SIGNATURE----- --=-Ym35/rhkSLqa3r+SwvB/-- --===============0456355509== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0456355509==--