Re: [PATCH 2/8] drm/i915: Change get_existing_crtc_state to old state

Mahesh Kumar
2017-08-01T08:00:15Z

On Tuesday 01 August 2017 01:23 PM, Maarten Lankhorst wrote:
> Hey,
>
> Op 01-08-17 om 08:46 schreef Mahesh Kumar:
>> Hi,
>>
>> As per my understanding "get_existing_*_state == get_new_*_state"
>>
>> It looks like you are trying to use currently available unused wrapper for completely different purpose. But IMHO you should create a new wrapper for get_old_state
>>
>> & this should be renamed to get_new_state. :)
> This really depends, and is the reason why we have to rename this.
>
> Before commit:
> get_existing_state == get_new_state
>
> After commit:
> get_existing_state == get_old_state.
yeah, right :)
>
> Perhaps I can add both in this patch, I'll clean the series up slightly.
sounds good
-Mahesh
>