Re: [PATCH 1/4] drm: Support legacy cursor ioctls via universal planes when possible (v2)

Daniel Vetter
2014-05-20T07:24:47Z

On Mon, May 19, 2014 at 03:25:45PM -0700, Matt Roper wrote:
> On Sat, May 17, 2014 at 12:43:04AM +0200, Daniel Vetter wrote:
> > On Sat, May 17, 2014 at 12:38 AM, Matt Roper <matthew.d.roper@intel.com> wrote:
> > > + if (ret) {
> > > + if (req->flags & DRM_MODE_CURSOR_BO)
> > > + drm_mode_rmfb(dev, &fb->base.id, file_priv);
> > > + return ret;
> > > + }
> >
> > With the new refcount logic an unconditional
> > drm_framebuffer_unreference should be here instead of this. I think,
> > but please double-check since it's late here ;-)
> > -Daniel
>
> Actually, I'm not sure if we want the unreference at all.
> setplane_internal() unrefs fb on failure (and old_fb on success), so I
> think that's already taken care of.

Oh right, I've forgotten about that part. A one-line comment here that
setplane_internal will eat the reference would be good - you already have
a corresponding comment around setplane_internal but I guess that's not
good enough for silly me ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch