From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 1/2] drm/i915: do runtime_get/put during display well power gate/ungate Date: Tue, 10 Jun 2014 15:24:34 +0300 Message-ID: <1402403074.7876.51.camel@intelbox> References: <1402340250-3909-1-git-send-email-sagar.a.kamble@intel.com> <1402340250-3909-2-git-send-email-sagar.a.kamble@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0355145445==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id C90BD6E687 for ; Tue, 10 Jun 2014 05:24:37 -0700 (PDT) In-Reply-To: <1402340250-3909-2-git-send-email-sagar.a.kamble@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: sagar.a.kamble@intel.com Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, shashidhar.hiremath@intel.com List-Id: intel-gfx@lists.freedesktop.org --===============0355145445== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-R+GaJCPrU9bc0RHXdr2I" --=-R+GaJCPrU9bc0RHXdr2I Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Sagar, On Tue, 2014-06-10 at 00:27 +0530, sagar.a.kamble@intel.com wrote: > From: Sagar Kamble >=20 > Display power island is on during boot, we have one count for it > once this power gates, we do a put making sure runtime_suspend is > called >=20 > Cc: Daniel Vetter (supporter:INTEL DRM DRIVERS..= .) > Cc: Jani Nikula (supporter:INTEL DRM DRIVER= S...) > Signed-off-by: Sagar Kamble > --- > drivers/gpu/drm/i915/intel_pm.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel= _pm.c > index f83d1ff..b333aae 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -6017,6 +6017,12 @@ void __vlv_set_power_well(struct drm_i915_private = *dev_priv, > state, > vlv_punit_read(dev_priv, PUNIT_REG_PWRGT_CTRL)); > =20 > + if (PUNIT_POWER_WELL_DISP2D =3D=3D power_well_id) { > + if (enable) > + intel_runtime_pm_get(dev_priv); > + else > + intel_runtime_pm_put(dev_priv); > + } The RPM refcount should already be get/put properly in intel_display_power_get/put(), so the above doesn't seem correct to me. With current -nightly after blanking the screen the RPM refcount does drop to 0 for me, so I'm not sure what you're missing. One possibility is: # echo auto > /sys/bus/pci/devices/0000:00:02.0/power/control --Imre --=-R+GaJCPrU9bc0RHXdr2I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTlvkCAAoJEORIIAnNuWDFP+4H/1TuXyYcmvvG06Lwhaxjbh0U utjZRe/LhDWb5PnOHpQ87C9pxkBkVNLyMszYNKmyLeH3JkYO+uZipbKeagzdQOzK N2OXIxHovApvmDhzUIjZj7Eu+RYYVwesx7NKV+pUusNNJALmfQDq4rJJtHQhT2vx nddvDum5ThkvHC/xEQBDqXIvnXLuplzVzf8akOrlOYqPfA1f13ZKboAb4K4UGB6f PmYpYkH/FkF2jMKt1RDM6elID2C4hBLbFU2SBwtRKEKyETnH3akbyLCmGQeWBBeR tS+0Io9Pscuji2GHxLqRgSeMHOQEdBoZEv3QEYeUScYh8gROJY6qaPYXbEwsANM= =kPLl -----END PGP SIGNATURE----- --=-R+GaJCPrU9bc0RHXdr2I-- --===============0355145445== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0355145445==--