Re: [PATCH 11/11] tests/kms_rotation_crc: IGT for 180 degree HW rotation

Jindal, Sonika
2014-06-18T12:00:52Z

On 6/18/2014 5:02 PM, Damien Lespiau wrote:
> On Wed, Jun 18, 2014 at 02:27:27PM +0530, sonika.jindal@intel.com wrote:
>> From: Sonika Jindal <sonika.jindal@intel.com>
>>
>> Testcase for 180 degree HW rotation
>>
>> Cc: sagar.a.kamble@intel.com
>>
>> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
>
> The test looks good to me (I haven't checked in details, the bar for igt
> is quite a bit lower). It shows two gaps in the igt kms API:
>
> - Retrieving the primary plane (there's a series from Matt fixing this
> and exposing the primary plane through igt_output_get_plane())
True, thats why I am checking for type property in this test. Can be
removed once Matt's patches are merged
> - Adding a set_property() convenience function
> (ala igt_plane_set_property("rotation", BIT(DRM_ROTATE_180)))
> (no-one is working on that just yet, can de done later)
Sure, will be good to have.
>
> A small question before pushing this, have you checked that the test
> correctly skips when running with a kernel without rotation support?
NO, I haven't tested that. Will try in sometime and let you know if I
see any issue there.
>
> Thanks,
>