From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 2/2] drm/i915: don't take runtime PM reference around freeze/thaw Date: Thu, 19 Jun 2014 16:25:55 +0300 Message-ID: <1403184355.27481.8.camel@intelbox> References: <1403110376-1889-1-git-send-email-jbarnes@virtuousgeek.org> <1403110376-1889-2-git-send-email-jbarnes@virtuousgeek.org> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1866491578==" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id D299A6E8AA for ; Thu, 19 Jun 2014 06:26:09 -0700 (PDT) In-Reply-To: <1403110376-1889-2-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1866491578== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-tdD9Li12cMYF+YNj2Wy0" --=-tdD9Li12cMYF+YNj2Wy0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2014-06-18 at 09:52 -0700, Jesse Barnes wrote: > We should be taking the right power well refs these days, so this > shouldn't be necessary. It also gets in the way of re-using these > routines for S0iX states, as those need all the power saving features > enabled. >=20 > Signed-off-by: Jesse Barnes Reviewed-by: Imre Deak Btw, we also have the same redundancy in intel_dp_detect(). --Imre > --- > drivers/gpu/drm/i915/i915_drv.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_= drv.c > index be97741..6eb45ac 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -496,8 +496,6 @@ static int i915_drm_freeze(struct drm_device *dev) > struct drm_crtc *crtc; > pci_power_t opregion_target_state; > =20 > - intel_runtime_pm_get(dev_priv); > - > /* ignore lid events during suspend */ > mutex_lock(&dev_priv->modeset_restore_lock); > dev_priv->modeset_restore =3D MODESET_SUSPENDED; > @@ -686,7 +684,6 @@ static int __i915_drm_thaw(struct drm_device *dev, bo= ol restore_gtt_mappings) > =20 > intel_opregion_notify_adapter(dev, PCI_D0); > =20 > - intel_runtime_pm_put(dev_priv); > return 0; > } > =20 --=-tdD9Li12cMYF+YNj2Wy0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTouTjAAoJEORIIAnNuWDF7P4H/AkTNcDUqtYgf/xz54Kw00WW 5iG+6hKDQ/tP1VfOHBgrFxLkk+PrXzcKgBLGwRXAM62lKQdtHXY8wqX7D9di8N0Z CqEIxUW3NI1mGkdOYveFRs/gHzkpKkiwu9D/DnNsWkxsf/11F7GE+KuGHoWbp4CU YYg7d/8gEDu71Z7E4a9GRQWX7zF79vGfTTpYZmp6mO9fC/sGqZ5khAh0nSh7dwuG dtYxtld/VPoZK9exyY6YIbjDrp9uXvSOUQLh2+9F3pfqjsdXDhGhhDCF2rrPO+Db MGLUROtY7BfJy5hdb+dMz6rtZJRZUNPtjXxWYpF+4P4JCTaUjLslMpPrUgR7mp8= =EfRu -----END PGP SIGNATURE----- --=-tdD9Li12cMYF+YNj2Wy0-- --===============1866491578== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1866491578==--