public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 1/5] drm/i915: don't write powered down IRQ registers on Gen 8
Date: Fri,  4 Jul 2014 11:50:29 -0300	[thread overview]
Message-ID: <1404485433-4488-2-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1404485433-4488-1-git-send-email-przanoni@gmail.com>

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

If we enable unclaimed register reporting on Gen 8, we will discover
that the IRQ registers for pipes B and C are also on the power well,
so writes to them when the power well is disabled result in unclaimed
register errors.

Also, hsw_power_well_post_enable() already takes care of re-enabling
them once the power well is enabled.

Testcase: igt/pm_rpm/rte
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 1c1ec22..2e116e9d 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -3193,7 +3193,9 @@ static void gen8_irq_reset(struct drm_device *dev)
 	gen8_gt_irq_reset(dev_priv);
 
 	for_each_pipe(pipe)
-		GEN8_IRQ_RESET_NDX(DE_PIPE, pipe);
+		if (intel_display_power_enabled(dev_priv,
+						POWER_DOMAIN_PIPE(pipe)))
+			GEN8_IRQ_RESET_NDX(DE_PIPE, pipe);
 
 	GEN5_IRQ_RESET(GEN8_DE_PORT_);
 	GEN5_IRQ_RESET(GEN8_DE_MISC_);
@@ -3526,8 +3528,11 @@ static void gen8_de_irq_postinstall(struct drm_i915_private *dev_priv)
 	dev_priv->de_irq_mask[PIPE_C] = ~de_pipe_masked;
 
 	for_each_pipe(pipe)
-		GEN8_IRQ_INIT_NDX(DE_PIPE, pipe, dev_priv->de_irq_mask[pipe],
-				  de_pipe_enables);
+		if (intel_display_power_enabled(dev_priv,
+				POWER_DOMAIN_PIPE(pipe)))
+			GEN8_IRQ_INIT_NDX(DE_PIPE, pipe,
+					  dev_priv->de_irq_mask[pipe],
+					  de_pipe_enables);
 
 	GEN5_IRQ_INIT(GEN8_DE_PORT_, ~GEN8_AUX_CHANNEL_A, GEN8_AUX_CHANNEL_A);
 }
-- 
2.0.0

  reply	other threads:[~2014-07-04 14:50 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04 14:50 [PATCH 0/5] BDW unclaimed registers Paulo Zanoni
2014-07-04 14:50 ` Paulo Zanoni [this message]
2014-07-07 21:23   ` [PATCH 1/5] drm/i915: don't write powered down IRQ registers on Gen 8 Daniel Vetter
2014-07-08 14:15     ` Paulo Zanoni
2014-07-08 14:58       ` Daniel Vetter
2014-07-10 19:31         ` Paulo Zanoni
2014-07-15 16:42           ` Rodrigo Vivi
2014-07-04 14:50 ` [PATCH 2/5] drm/i915: HSW_BLC_PWM2_CTL doesn't exist on BDW Paulo Zanoni
2014-07-15 16:43   ` Rodrigo Vivi
2014-07-04 14:50 ` [PATCH 3/5] drm/i915: extract and improve gen8_irq_power_well_post_enable Paulo Zanoni
2014-07-15 17:25   ` Rodrigo Vivi
2014-07-04 14:50 ` [PATCH 4/5] drm/i915: reorganize the unclaimed register detection code Paulo Zanoni
2014-07-07 21:34   ` Daniel Vetter
2014-07-15 19:17     ` Rodrigo Vivi
2014-07-04 14:50 ` [PATCH 5/5] drm/i915: BDW can also detect unclaimed registers Paulo Zanoni
2014-07-15 19:20   ` Rodrigo Vivi
2014-07-16 13:57     ` Daniel Vetter
2014-07-16 20:49       ` [PATCH 1/2] drm/i915: reorganize the unclaimed register detection code Paulo Zanoni
2014-07-16 20:49         ` [PATCH 2/2] drm/i915: BDW can also detect unclaimed registers Paulo Zanoni
2014-07-17  8:33           ` Daniel Vetter
2014-08-26 10:22         ` [PATCH 1/2] drm/i915: reorganize the unclaimed register detection code Chris Wilson
2014-08-26 12:17           ` Paulo Zanoni
2014-08-26 12:42             ` Chris Wilson
2014-08-26 13:04               ` Paulo Zanoni
2014-08-26 13:18                 ` Chris Wilson
2014-08-26 13:29                   ` Paulo Zanoni
2014-08-26 13:34                     ` Daniel Vetter
2014-08-26 13:46                       ` Chris Wilson
2014-08-26 14:08                         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404485433-4488-2-git-send-email-przanoni@gmail.com \
    --to=przanoni@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox