Re: [v3 09/13] drm/i915: Add rotation property for sprites

Daniel Vetter
2014-07-11T22:10:31Z

On Tue, Jul 08, 2014 at 10:31:59AM +0530, sonika.jindal@intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Sprite planes support 180 degree rotation. The lower layers are now in
> place, so hook in the standard rotation property to expose the feature
> to the users.
>
> v2: Moving rotation_property to drm_plane
>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_sprite.c | 40 ++++++++++++++++++++++++++++++++++-
> include/drm/drm_crtc.h | 1 +

One more: A patch titled with "drm/i915: ..." really shouldn't touch
anything outside of drm/i915 directories and so shouldn't introduce any
changes to core drm code. Such changes always need to be split out into a
separate drm patch. Exceptions (like refactoring function interfaces)
obviously apply.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch