From: Paul Bolle <pebolle@tiscali.nl>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Track the primary plane correctly when reassigning planes
Date: Mon, 14 Jul 2014 19:58:15 +0200 [thread overview]
Message-ID: <1405360695.13661.5.camel@x220> (raw)
In-Reply-To: <1405359549-12063-1-git-send-email-daniel.vetter@ffwll.ch>
On Mon, 2014-07-14 at 19:39 +0200, Daniel Vetter wrote:
> commit 98ec77397a5c68ce753dc283aaa6f4742328bcdd
> Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Date: Wed Apr 30 17:43:01 2014 +0300
>
> drm/i915: Make primary_enabled match the actual hardware state
>
> introduced more accurate tracking of the primary plane and some
> checks. It missed the plane->pipe reassignement code for gen2/3
> though, which the checks caught and resulted in WARNING backtraces.
>
> Since we only use this path if the plane is on and on the wrong pipe
> we can just always set the tracking bit to "enabled".
>
> Reported-and-tested-by: Paul Bolle <pebolle@tiscali.nl>
Maybe that should be something like:
Reported-bisected-and-tested-by: Paul Bolle <pebolle@tiscali.nl>
> Cc: Paul Bolle <pebolle@tiscali.nl>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/intel_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 82e7d57f0a8a..f0be855ddf45 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -11914,6 +11914,7 @@ static void intel_sanitize_crtc(struct intel_crtc *crtc)
> * ... */
> plane = crtc->plane;
> crtc->plane = !plane;
> + crtc->primary_enabled = true;
> dev_priv->display.crtc_disable(&crtc->base);
> crtc->plane = plane;
>
(I don't do smilies. This is a joke!)
Paul Bolle
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-07-14 17:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 17:39 [PATCH] drm/i915: Track the primary plane correctly when reassigning planes Daniel Vetter
2014-07-14 17:58 ` Paul Bolle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405360695.13661.5.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox