Re: [PATCH 1/2] drm/i915: reorganize the unclaimed register detection code

Chris Wilson
2014-08-26T10:22:35Z

On Wed, Jul 16, 2014 at 05:49:29PM -0300, Paulo Zanoni wrote:
> static void
> -hsw_unclaimed_reg_check(struct drm_i915_private *dev_priv, u32 reg)
> +hsw_unclaimed_reg_detect(struct drm_i915_private *dev_priv)
> {
> + if (i915.mmio_debug)
> + return;
> +
> if (__raw_i915_read32(dev_priv, FPGA_DBG) & FPGA_DBG_RM_NOCLAIM) {
> - DRM_ERROR("Unclaimed write to %x\n", reg);
> + DRM_ERROR("Unclaimed register detected. Please use the i915.mmio_debug=1 to debug this problem.");
> __raw_i915_write32(dev_priv, FPGA_DBG, FPGA_DBG_RM_NOCLAIM);
> }

What was the point here? You still add an extra read to every register
write and then repeat the request to enable mmio_debug ad infinitum. And
you still check for illegal writes in the irq handler.

Just kill this code.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre