public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Robert Bragg <robert.bragg@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 5/9] intel_reg: rename RING_LEN RING_CTL
Date: Fri, 18 Jul 2014 16:38:49 +0100	[thread overview]
Message-ID: <1405697933-30152-6-git-send-email-robert.bragg@intel.com> (raw)
In-Reply-To: <1405697933-30152-1-git-send-email-robert.bragg@intel.com>

This register holds more than the length. This also renames the lsb to
RING_ENABLED.
---
 lib/intel_reg.h       | 7 ++-----
 tools/intel_gpu_top.c | 2 +-
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/lib/intel_reg.h b/lib/intel_reg.h
index 56459ea..8a6e3f1 100644
--- a/lib/intel_reg.h
+++ b/lib/intel_reg.h
@@ -662,17 +662,14 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #define START_ADDR          0x03FFFFF8
 #define I830_RING_START_MASK	0xFFFFF000
 
-#define RING_LEN       0x0C
+#define RING_CTL       0x0C
 #define RING_NR_PAGES       0x001FF000 
 #define I830_RING_NR_PAGES	0x001FF000
 #define RING_REPORT_MASK    0x00000006
 #define RING_REPORT_64K     0x00000002
 #define RING_REPORT_128K    0x00000004
 #define RING_NO_REPORT      0x00000000
-#define RING_VALID_MASK     0x00000001
-#define RING_VALID          0x00000001
-#define RING_INVALID        0x00000000
-
+#define RING_ENABLED_MASK   0x00000001
 
 
 /* BitBlt Instructions
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 3115b5e..6e494b1 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -357,7 +357,7 @@ static uint32_t ring_read(struct ring *ring, uint32_t reg)
 
 static void ring_init(struct ring *ring)
 {
-	ring->size = (((ring_read(ring, RING_LEN) & RING_NR_PAGES) >> 12) + 1) * 4096;
+	ring->size = (((ring_read(ring, RING_CTL) & RING_NR_PAGES) >> 12) + 1) * 4096;
 }
 
 static void ring_reset(struct ring *ring)
-- 
2.0.1

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

  parent reply	other threads:[~2014-07-18 15:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18 15:38 [PATCH 0/9] intel-gpu-top improvements Robert Bragg
2014-07-18 15:38 ` [PATCH 1/9] intel_gpu_top: don't fclose NULL output Robert Bragg
2014-07-18 15:38 ` [PATCH 2/9] intel_gpu_top: aim for 2000 samples per frame Robert Bragg
2014-07-18 15:38 ` [PATCH 3/9] intel_gpu_top: ignore out of range ring pointers Robert Bragg
2014-07-18 15:38 ` [PATCH 4/9] intel_gpu_top: read max/current gt freq via sysfs Robert Bragg
2014-07-18 15:38 ` Robert Bragg [this message]
2014-07-18 15:38 ` [PATCH 6/9] intel_reg: add RING_CCID current context ID reg Robert Bragg
2014-07-18 15:38 ` [PATCH 7/9] instdone: Add human readable names for HSW Robert Bragg
2014-07-18 15:38 ` [PATCH 8/9] intel_gpu_top: account for per context statistics Robert Bragg
2014-07-18 15:38 ` [PATCH 9/9] intel_gpu_top: hide absolute counter values Robert Bragg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405697933-30152-6-git-send-email-robert.bragg@intel.com \
    --to=robert.bragg@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox