Re: [PATCH] drm/i915: WARN if module opt sanitization goes out of order

Damien Lespiau
2014-08-11T14:29:58Z

On Mon, Aug 11, 2014 at 03:59:52PM +0200, Daniel Vetter wrote:
> Depending upon one module option to be sanitized (through USES_PPGTT)
> for the other is a bit too fragile for my taste. At least WARN about
> this.
>
> Cc: Ben Widawsky <ben@bwidawsk.net>
> Cc: Damien Lespiau <damien.lespiau@intel.com>
> Cc: Oscar Mateo <oscar.mateo@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Sounds like a safety measure we'd want. Until we try to fix these kind
of dependencies in a more adequate manner that is.

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

--
Damien

> ---
> drivers/gpu/drm/i915/intel_lrc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 21f7f1cce86e..44721292eb77 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -43,6 +43,8 @@
>
> int intel_sanitize_enable_execlists(struct drm_device *dev, int enable_execlists)
> {
> + WARN_ON(i915.enable_ppgtt == -1);
> +
> if (enable_execlists == 0)
> return 0;
>
> --
> 2.0.1
>