Re: [PATCH 16/40] drm/i915: Add chv_power_wells[]

Daniel Vetter
2014-07-30T11:18:00Z

On Fri, Jul 11, 2014 at 02:09:40PM +0000, Barbalho, Rafael wrote:
>
>
> > -----Original Message-----
> > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf
> > Of ville.syrjala@linux.intel.com
> > Sent: Saturday, June 28, 2014 12:04 AM
> > To: intel-gfx@lists.freedesktop.org
> > Subject: [Intel-gfx] [PATCH 16/40] drm/i915: Add chv_power_wells[]
> >
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Add chv_power_wells[] so we can start to build up the power well support
> > for chv. Just the "always on" well there initialy.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_pm.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c
> > b/drivers/gpu/drm/i915/intel_pm.c
> > index 898654f..e2b956e 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -6498,6 +6498,15 @@ static struct i915_power_well vlv_power_wells[] =
> > {
> > },
> > };
> >
> > +static struct i915_power_well chv_power_wells[] = {
> > + {
> > + .name = "always-on",
> > + .always_on = 1,
> > + .domains = VLV_ALWAYS_ON_POWER_DOMAINS,
> > + .ops = &i9xx_always_on_power_well_ops,
> > + },
> > +};
> > +
> > static struct i915_power_well *lookup_power_well(struct drm_i915_private
> > *dev_priv,
> > enum punit_power_well
> > power_well_id)
> > {
> > @@ -6534,6 +6543,8 @@ int intel_power_domains_init(struct
> > drm_i915_private *dev_priv)
> > } else if (IS_BROADWELL(dev_priv->dev)) {
> > set_power_wells(power_domains, bdw_power_wells);
> > hsw_pwr = power_domains;
> > + } else if (IS_CHERRYVIEW(dev_priv->dev)) {
> > + set_power_wells(power_domains, chv_power_wells);
> > } else if (IS_VALLEYVIEW(dev_priv->dev)) {
> > set_power_wells(power_domains, vlv_power_wells);
> > } else {
> > --
> > 1.8.5.5
> >
>
> Tested-by: Rafael Barbalho <rafael.barbalho@intel.com>

Ok, pulled this one in too to undo my giant merge fumble. My apologies to
everyone for the mess.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch