Re: [PATCH 10/40] drm/i915: Call encoder->post_disable() in intel_sanitize_encoder()

Barbalho, Rafael
2014-07-11T14:47:04Z

> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf
> Of ville.syrjala@linux.intel.com
> Sent: Saturday, June 28, 2014 12:04 AM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 10/40] drm/i915: Call encoder->post_disable() in
> intel_sanitize_encoder()
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> VLV and CHV disable the DP port only in the .post_disable() hook, so we
> need to make intel_sanitize_encoder() call that when it's trying to
> disable encoders without an active pipes.
>
> My bsw actaully hits this when an external display is connected. The
> BIOS still likes to turn on the eDP port, but leaves the pipe disabled.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index 3e4d570..a16f635 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12772,6 +12772,8 @@ static void intel_sanitize_encoder(struct
> intel_encoder *encoder)
> encoder->base.base.id,
> encoder->base.name);
> encoder->disable(encoder);
> + if (encoder->post_disable)
> + encoder->post_disable(encoder);
> }
> encoder->base.crtc = NULL;
> encoder->connectors_active = false;
> --
> 1.8.5.5
>

I haven't done as much DP testing on my CHT but that makes sense.

Reviewed-by: Rafael Barbalho <rafael.barbalho@intel.com>

> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx