From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 1/3] drm/i915: Update DDL only for current CRTC Date: Thu, 31 Jul 2014 15:53:53 +0300 Message-ID: <1406811233.18327.16.camel@intelbox> References: <1405515245-14946-1-git-send-email-gajanan.bhat@intel.com> <1405515245-14946-2-git-send-email-gajanan.bhat@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1549458696==" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F00B6E105 for ; Thu, 31 Jul 2014 05:54:00 -0700 (PDT) In-Reply-To: <1405515245-14946-2-git-send-email-gajanan.bhat@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Gajanan Bhat Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1549458696== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-9dmm5eYwXNAMgfVg36zd" --=-9dmm5eYwXNAMgfVg36zd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2014-07-16 at 18:24 +0530, Gajanan Bhat wrote: > Instead of looping through all CRTCs, update DDL for current CRTC for whi= ch > watermark is being updated. > CHV is confirmed to have precision of 32/64 which is same as VLV. >=20 > Signed-off-by: Gajanan Bhat Looks ok to me: Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/intel_pm.c | 25 +++++++++---------------- > 1 file changed, 9 insertions(+), 16 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel= _pm.c > index b881639..90df1e8 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -1307,24 +1307,17 @@ static bool vlv_compute_drain_latency(struct drm_= device *dev, > * latency value. > */ > =20 > -static void vlv_update_drain_latency(struct drm_device *dev) > +static void vlv_update_drain_latency(struct drm_crtc *crtc) > { > + struct drm_device *dev =3D crtc->dev; > struct drm_i915_private *dev_priv =3D dev->dev_private; > - enum pipe pipe; > - > - for_each_pipe(pipe) { > - int plane_prec, plane_dl; > - int cursor_prec, cursor_dl; > - int plane_prec_mult, cursor_prec_mult; > + enum pipe pipe =3D to_intel_crtc(crtc)->pipe; > + int plane_prec, plane_dl; > + int cursor_prec, cursor_dl; > + int plane_prec_mult, cursor_prec_mult; > =20 > - if (!vlv_compute_drain_latency(dev, pipe, &plane_prec_mult, &plane_dl, > - &cursor_prec_mult, &cursor_dl)) > - continue; > - > - /* > - * FIXME CHV spec still lists 16 and 32 as the precision > - * values. Need to figure out if spec is outdated or what. > - */ > + if (vlv_compute_drain_latency(dev, pipe, &plane_prec_mult, &plane_dl, > + &cursor_prec_mult, &cursor_dl)) { > cursor_prec =3D (cursor_prec_mult =3D=3D DRAIN_LATENCY_PRECISION_64) ? > DDL_CURSOR_PRECISION_64 : DDL_CURSOR_PRECISION_32; > plane_prec =3D (plane_prec_mult =3D=3D DRAIN_LATENCY_PRECISION_64) ? > @@ -1349,7 +1342,7 @@ static void valleyview_update_wm(struct drm_crtc *c= rtc) > unsigned int enabled =3D 0; > bool cxsr_enabled; > =20 > - vlv_update_drain_latency(dev); > + vlv_update_drain_latency(crtc); > =20 > if (g4x_compute_wm0(dev, PIPE_A, > &valleyview_wm_info, latency_ns, --=-9dmm5eYwXNAMgfVg36zd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJT2jxhAAoJEORIIAnNuWDFcn4H/RBZUI4bJVkONQ3ISlpICbc6 Thcae+Ee6MeUnmMS7lr2qCg68rTZIJZmMLSOynCLFyMlSwEFQHDhmPe4mqcRhi3j NsYLy5aIM9Jxy2OHIXreSvmStSaqaMt1nZbiEykHLBMEDMsJcZjs6uvdxetY/ArH +BaUNZpycu2cZ+CX9XBVDTQdRHQfb9kQhZi6g56eHFlm76LQO8MRiNe/A/ER81Xu h8QrCtaMindaeOvG3SIvqek4TORrsUHq3cFPVj5vtpoVLYkdJF5108GpuEY/Bhuq 8lWIcwr4AdNp6DRXKwU5gGMwXZA8Jqrcz1/JyoOkVxyBdOFdjKLjvLC6JknfR60= =0Sb3 -----END PGP SIGNATURE----- --=-9dmm5eYwXNAMgfVg36zd-- --===============1549458696== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1549458696==--